All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Angelo Dell'Aera" <buffer@antifork.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Linux-Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel 2.6.5-mm1 : laptop-mode
Date: Tue, 6 Apr 2004 00:33:59 +0200	[thread overview]
Message-ID: <20040406003359.7d3d8d5a.buffer@antifork.org> (raw)
In-Reply-To: <20040405145209.4904aec5.akpm@osdl.org>

On Mon, 5 Apr 2004 14:52:09 -0700
Andrew Morton <akpm@osdl.org> wrote:

>"Angelo Dell'Aera" <buffer@antifork.org> wrote:
>>
>> After upgrading to 2.6.5-mm1 I noticed the script laptop_mode
>> failed to initiliaze laptop mode. It is due to the new position
>> of the sysctl laptop_mode under /proc. This is an update to the
>> documentation (and the script). Please apply.
>> ...
>>  
>> -Laptop-mode is controlled by the flag /proc/sys/vm/laptop_mode. When this
>> +Laptop-mode is controlled by the flag /proc/sys/fs/laptop_mode. When this
>
>erk.  No, that was not intended.  Looks like `patch' decided to move some code around
>for me.  I'll fix that up, thanks.  laptop_mode shall remain in /proc/sys/vm/

OK. Attached a patch which addresses this matter.

Regards.

--

Angelo Dell'Aera 'buffer' 
Antifork Research, Inc.	  	http://buffer.antifork.org




--- linux-2.6.5-mm1/kernel/sysctl.c.old	2004-04-06 00:26:15.000000000 +0200
+++ linux-2.6.5-mm1/kernel/sysctl.c	2004-04-06 00:28:29.000000000 +0200
@@ -744,6 +744,26 @@
 		.mode		= 0644,
 		.proc_handler	= &proc_dointvec
 	},
+	{
+		.ctl_name	= VM_LAPTOP_MODE,
+		.procname	= "laptop_mode",
+		.data		= &laptop_mode,
+		.maxlen		= sizeof(laptop_mode),
+		.mode		= 0644,
+		.proc_handler	= &proc_dointvec,
+		.strategy	= &sysctl_intvec,
+		.extra1		= &zero,
+	},
+	{
+		.ctl_name	= VM_BLOCK_DUMP,
+		.procname	= "block_dump",
+		.data		= &block_dump,
+		.maxlen		= sizeof(block_dump),
+		.mode		= 0644,
+		.proc_handler	= &proc_dointvec,
+		.strategy	= &sysctl_intvec,
+		.extra1		= &zero,
+	},
 	{ .ctl_name = 0 }
 };
 
@@ -854,26 +874,6 @@
 		.mode		= 0644,
 		.proc_handler	= &proc_dointvec,
 	},
-	{
-		.ctl_name	= VM_LAPTOP_MODE,
-		.procname	= "laptop_mode",
-		.data		= &laptop_mode,
-		.maxlen		= sizeof(laptop_mode),
-		.mode		= 0644,
-		.proc_handler	= &proc_dointvec,
-		.strategy	= &sysctl_intvec,
-		.extra1		= &zero,
-	},
-	{
-		.ctl_name	= VM_BLOCK_DUMP,
-		.procname	= "block_dump",
-		.data		= &block_dump,
-		.maxlen		= sizeof(block_dump),
-		.mode		= 0644,
-		.proc_handler	= &proc_dointvec,
-		.strategy	= &sysctl_intvec,
-		.extra1		= &zero,
-	},
 	{ .ctl_name = 0 }
 };
 




      reply	other threads:[~2004-04-05 22:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-05 13:50 [PATCH] kernel 2.6.5-mm1 : laptop-mode Angelo Dell'Aera
2004-04-05 21:52 ` Andrew Morton
2004-04-05 22:33   ` Angelo Dell'Aera [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040406003359.7d3d8d5a.buffer@antifork.org \
    --to=buffer@antifork.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.