From: Jeremy Higdon <jeremy@sgi.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, jbarnes@sgi.com, davidm@hpl.hp.com
Subject: Re: 2.6.5-mm2 (build error in arch/ia64/kernel/setup.c)
Date: Wed, 7 Apr 2004 02:08:45 -0700 [thread overview]
Message-ID: <20040407090845.GA790466@sgi.com> (raw)
In-Reply-To: <20040406223321.704682ed.akpm@osdl.org>
I get a build error in arch/ia64/kernel/setup.c.
This patch fixes it for SN2 machines, but I don't claim it is Correct.
In fact, I think it is Wrong.
There have been changes to setup_arch(), including, apparently, the
elimination of the cmdline_p argument. Unforunately, that argument
was not completely purged from the function.
platform_setup on SN2 is #define'd to sn_setup, which still takes
the argument, but does not use it. So this hack works. I don't
know about the other IA64s.
I'm not sure exactly what was intended with these changes, so I
haven't attempted a Correct patch.
jeremy
--- arch/ia64/kernel/setup.c.old 2004-04-07 02:00:01.000000000 -0700
+++ arch/ia64/kernel/setup.c 2004-04-07 01:37:15.000000000 -0700
@@ -361,7 +361,7 @@
/* enable IA-64 Machine Check Abort Handling */
ia64_mca_init();
- platform_setup(cmdline_p);
+ platform_setup((void *) 0);
paging_init();
}
next prev parent reply other threads:[~2004-04-07 9:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-07 5:33 2.6.5-mm2 Andrew Morton
2004-04-07 6:51 ` 2.6.5-mm2 Brice Goglin
2004-04-07 7:08 ` 2.6.5-mm2 Brice Goglin
2004-04-07 7:10 ` 2.6.5-mm2 Andrew Morton
2004-04-07 7:15 ` 2.6.5-mm2 Brice Goglin
2004-04-07 13:24 ` 2.6.5-mm2 James Bottomley
2004-04-09 15:37 ` 2.6.5-mm2 (swsusp not working and acpi problem) Martin Hermanowski
2004-04-07 9:08 ` Jeremy Higdon [this message]
[not found] ` <20040407105832.39547a4e.akpm@osdl.org>
[not found] ` <1081381848.10944.67.camel@bach>
2004-04-08 0:32 ` 2.6.5-mm2 (build error in arch/ia64/kernel/setup.c) Andrew Morton
2004-04-08 1:00 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040407090845.GA790466@sgi.com \
--to=jeremy@sgi.com \
--cc=akpm@osdl.org \
--cc=davidm@hpl.hp.com \
--cc=jbarnes@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.