From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: linux-arch@vger.kernel.org
Cc: akpm@osdl.org
Subject: Re: [PATCH] missing NULL pointer check in pte_alloc_one.
Date: Wed, 7 Apr 2004 18:23:19 +0200 [thread overview]
Message-ID: <20040407162319.GA2274@mschwid3.boeblingen.de.ibm.com> (raw)
Hi Andrew,
stupid cut-copy-paste error. I fixed the problem for alpha and sparc64
but I broke s390. pte_alloc_one shouldn't allocate two pages, return one
and forget the other without freeing it...
blue skies,
Martin.
diff -urN linux-2.6/include/asm-s390/pgalloc.h linux-2.6-pgalloc/include/asm-s390/pgalloc.h
--- linux-2.6/include/asm-s390/pgalloc.h Wed Apr 7 18:17:19 2004
+++ linux-2.6-pgalloc/include/asm-s390/pgalloc.h Wed Apr 7 18:16:50 2004
@@ -141,7 +141,7 @@
{
pte_t *pte = pte_alloc_one_kernel(mm, vmaddr);
if (pte)
- return virt_to_page(pte_alloc_one_kernel(mm, vmaddr));
+ return virt_to_page(pte);
return 0;
}
next reply other threads:[~2004-04-07 16:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-07 16:23 Martin Schwidefsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-04-01 19:07 [PATCH] missing NULL pointer check in pte_alloc_one Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040407162319.GA2274@mschwid3.boeblingen.de.ibm.com \
--to=schwidefsky@de.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-arch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.