RE: Fix wake GPE enabling

[Nate Lawson <nate-Y6VGUYTwhu0@public.gmane.org>]

On Thu, 8 Apr 2004, Moore, Robert wrote:
> Linux needs a user interface and some additional OSPM software to
> identify and program the wake devices, as well as handle the other
> information in the _PRW methods.
>
> The ACPI CA core subsystem will only identify wake vs. runtime GPEs.
>
> > -> wake_enable is not touched directly,
> > -> events/evgpeblk.c does not care, and according to your opinion,
> should
> >    not care.
> > -> acpi_enable_gpe is _only_ called by drivers/acpi/ec.c, which means
> it
> > is
> >    _not_ called for buttons, which are very clearly needed in most
> cases
> > to
> >    wake up a system.
> >
> > At least for buttons, the ACPI subsystem should enable their wake
> > functionality, e.g. the wake GPEs, unconditionally. Having to manually
> > enter
> > "echo powerbutton > /proc/acpi/wakeup_devices", as the patch in bug
> #1415
> > suggests, seems to be overly complicated. However, having this file as
> > override might be a valid option, I agree.
> >
>
> The ACPI CA core subsystem does NOT scan for particular devices (via the
> _HID, _UID, etc.)  The upper OSPM software already does this and is thus
> responsible for enabling individual devices and GPEs for wake-up,
> including the power button, lid button, etc.  This code apparently still
> needs to be written.

You mean like this code snippet?

-Nate

acpi_button_attach(device_t dev)
{
    if (sc->fixed) {
        AcpiClearEvent(event);
        status = AcpiInstallFixedEventHandler(event,
                        acpi_button_fixed_handler, sc);
    } else {
        status = AcpiInstallNotifyHandler(sc->button_handle,
                        ACPI_DEVICE_NOTIFY, acpi_button_notify_handler, sc);
    }

    acpi_device_enable_wake_capability(sc->button_handle, 1);
}

acpi_button_suspend(device_t dev)
{
    struct acpi_button_softc    *sc;

    sc = device_get_softc(dev);
    acpi_device_enable_wake_event(sc->button_handle);
    return (0);
}

acpi_device_enable_wake_capability(ACPI_HANDLE h, int enable)
{
    /*
     * All Power Resources referenced by elements 2 through N
     * of the _PRW object are put into the ON state.
     */

    (void)acpi_SetInteger(h, "_PSW", enable);
}

acpi_device_enable_wake_event(ACPI_HANDLE h)
{
    status = AcpiEvaluateObject(h, "_PRW", NULL, &prw_buffer);
    if (ACPI_FAILURE(status))
        return;

    switch (res->Package.Elements[0].Type) {
    case ACPI_TYPE_INTEGER:
        /*
         * If the data type of this package element is numeric, then this
         * _PRW package element is the bit index in the GPEx_EN, in the
         * GPE blocks described in the FADT, of the enable bit that is
         * enabled for the wake event.
         */
        status = AcpiEnableGpe(NULL, res->Package.Elements[0].Integer.Value,
                               ACPI_EVENT_WAKE_ENABLE);
}


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click