From: Matthew Wilcox <willy@debian.org>
To: Lester Hightower <hightowe@10east.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: Fix for memory leak problem in megaraid2.c /proc entries (fwd)
Date: Thu, 8 Apr 2004 16:38:35 +0100 [thread overview]
Message-ID: <20040408153835.GC18329@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <Pine.LNX.4.58.0404081126480.9356@les5.10east.com>
On Thu, Apr 08, 2004 at 11:29:20AM -0400, Lester Hightower wrote:
> This diff fixes a memory leak in megaraid2.c, v2.10.1 (Dec 03, 2003):
>
> [root@10east scsi]# diff megaraid2.c.MEMORY_LEAK.20040408.lhh megaraid2.c
> 3395c3395,3399
> < if( channel >= max_channels ) return 0;
> ---
> > if( channel >= max_channels ) {
> > pci_free_consistent(pdev, 256, scsi_inq, scsi_inq_dma_handle);
> > mega_free_inquiry(inquiry, dma_handle, pdev);
> > return 0;
> > }
FYI, in future please use diff -u to generate diffs; they are much more
robust and easier to read than the diff default.
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
next prev parent reply other threads:[~2004-04-08 15:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-08 15:29 Fix for memory leak problem in megaraid2.c /proc entries (fwd) Lester Hightower
2004-04-08 15:38 ` Matthew Wilcox [this message]
2004-04-08 15:41 ` Lester Hightower
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040408153835.GC18329@parcelfarce.linux.theplanet.co.uk \
--to=willy@debian.org \
--cc=hightowe@10east.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.