From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Date: Thu, 08 Apr 2004 17:51:26 +0000 Subject: Re: HUGETLB commit handling. Message-Id: <20040408175126.GA72736@colin2.muc.de> List-Id: References: <1IKJu-Zn-29@gated-at.bofh.it> <40758A74.3040107@sgi.com> In-Reply-To: <40758A74.3040107@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Ray Bryant Cc: Andi Kleen , Andy Whitcroft , "Chen, Kenneth W" , "Martin J. Bligh" , linux-kernel@vger.kernel.org, anton@samba.org, sds@epoch.ncsc.mil, ak@suse.de, lse-tech@lists.sourceforge.net, linux-ia64@vger.kernel.org > The other problem we are wrestling with is how to do the ia386 and ia64 > lazy allocation code without breaking the architectures that haven't yet > switched to lazy allocation. There will probbaly be some > > #define ARCH_USES_HUGETLB_PREFAULT > > nonsense added to deal with the latter, if needed. In my patch I just used weak functions: use a dummy weak function in the high level code and overwrite from the architecture specific code as needed. This avoids all the ifdefs. -Andi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262109AbUDHRwD (ORCPT ); Thu, 8 Apr 2004 13:52:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262106AbUDHRwC (ORCPT ); Thu, 8 Apr 2004 13:52:02 -0400 Received: from colin2.muc.de ([193.149.48.15]:54022 "HELO colin2.muc.de") by vger.kernel.org with SMTP id S262109AbUDHRv1 (ORCPT ); Thu, 8 Apr 2004 13:51:27 -0400 Date: 8 Apr 2004 19:51:26 +0200 Date: Thu, 8 Apr 2004 19:51:26 +0200 From: Andi Kleen To: Ray Bryant Cc: Andi Kleen , Andy Whitcroft , "Chen, Kenneth W" , "Martin J. Bligh" , linux-kernel@vger.kernel.org, anton@samba.org, sds@epoch.ncsc.mil, ak@suse.de, lse-tech@lists.sourceforge.net, linux-ia64@vger.kernel.org Subject: Re: HUGETLB commit handling. Message-ID: <20040408175126.GA72736@colin2.muc.de> References: <1IKJu-Zn-29@gated-at.bofh.it> <40758A74.3040107@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40758A74.3040107@sgi.com> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > The other problem we are wrestling with is how to do the ia386 and ia64 > lazy allocation code without breaking the architectures that haven't yet > switched to lazy allocation. There will probbaly be some > > #define ARCH_USES_HUGETLB_PREFAULT > > nonsense added to deal with the latter, if needed. In my patch I just used weak functions: use a dummy weak function in the high level code and overwrite from the architecture specific code as needed. This avoids all the ifdefs. -Andi