From: Greg KH <greg@kroah.com>
To: linux-hotplug@vger.kernel.org
Subject: Re: udev makefile patch
Date: Thu, 08 Apr 2004 20:15:45 +0000 [thread overview]
Message-ID: <20040408201545.GA12559@kroah.com> (raw)
In-Reply-To: <200404081909.41722.treeve01@pi.be>
On Thu, Apr 08, 2004 at 07:09:30PM +0200, Treeve Jelbert wrote:
> --- Makefile 2004-04-03 12:20:04.000000000 +0200
> +++ Makefile.cp 2004-04-03 12:26:20.000000000 +0200
> @@ -109,7 +109,6 @@
> OPTIMIZATION+=-fstrict-aliasing
> endif
> ifeq ($(strip $(TARGET_ARCH)),i386)
> - OPTIMIZATION+=-march=i386
Why is this necessary?
> OPTIMIZATION += ${shell if $(CC) -mpreferred-stack-boundary=2 -S -o /dev/null -xc \
> /dev/null >/dev/null 2>&1; then echo "-mpreferred-stack-boundary=2"; fi}
> OPTIMIZATION += ${shell if $(CC) -malign-functions=0 -malign-jumps=0 -S -o /dev/null -xc \
> @@ -384,7 +383,7 @@
> - rm $(mandir)/man8/udevd.8
> - rm $(mandir)/man8/udevsend.8
>
> -install: install-initscript install-config install-man install-dev.d all
> +install: install-man install-dev.d all
Why? Doesn't your package manager handle this?
> -ifndef DESTDIR
> - - killall udevd
> - - rm -f $(udevdir)/.udev.tdb
> -endif
Again, why? You should be setting DESTDIR if you are building for a
packagemanger, and if not, and you are building from scratch, into the
correct install directory, you really need to kill udevd.
thanks,
greg k-h
-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id\x1470&alloc_id638&op=click
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
prev parent reply other threads:[~2004-04-08 20:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-08 17:09 udev makefile patch Treeve Jelbert
2004-04-08 20:15 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040408201545.GA12559@kroah.com \
--to=greg@kroah.com \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.