From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by monty-python.gnu.org with archive (Exim 4.30) id 1BE5ET-0004ZI-S1 for mharc-grub-devel@gnu.org; Thu, 15 Apr 2004 07:40:37 -0400 Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1BE5EP-0004Y9-4h for grub-devel@gnu.org; Thu, 15 Apr 2004 07:40:33 -0400 Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1BE5Dq-0004S4-Il for grub-devel@gnu.org; Thu, 15 Apr 2004 07:40:29 -0400 Received: from [213.228.0.62] (helo=postfix4-1.free.fr) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BE5Dq-0004Rs-4S for grub-devel@gnu.org; Thu, 15 Apr 2004 07:39:58 -0400 Received: from openbrick.enbug.org (boitelle-1-82-66-127-114.fbx.proxad.net [82.66.127.114]) by postfix4-1.free.fr (Postfix) with ESMTP id A1015DFD6C for ; Thu, 15 Apr 2004 13:34:14 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by openbrick.enbug.org (Postfix) with ESMTP id 9BEBA177500 for ; Thu, 15 Apr 2004 15:35:05 +0200 (CEST) From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Thu, 15 Apr 2004 13:37:28 +0200 User-Agent: KMail/1.5.3 References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200404151337.28895.okuji@enbug.org> Subject: Re: grub fails to tftp a file with more than 64K blocks X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Apr 2004 11:40:35 -0000 On Wednesday 14 April 2004 04:39, Guzovsky, Eduard wrote: > Grub version 0.94 with (or without) "grub-0[1].94-diskless-1.patch" > fails to tftp a file with more than 64K blocks. Bellow is a fix. Note > that the bug exists in buf_fill() function. Thanks for your contribution, but this is not the right place to send your patch. grub-devel is used for GRUB 2 but not for GRUB legacy. bug-grub is used for patches against GRUB legacy instead. This time, I accept your patch here, but please use bug-grub rather than grub-devel from now on. Also, I'd like you to read the instructions on how to send patches in the manual. It should say that: 1. Unified format is desirable as a diff format. 2. Reverse patches are not good. 3. You should write a ChangeLog entry for your change. Okuji