All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@osdl.org>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: Chris Wright <chrisw@osdl.org>, Andrew Morton <akpm@osdl.org>,
	Jakub Jelinek <jakub@redhat.com>,
	Ulrich Drepper <drepper@redhat.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mq_open() honor leading slash
Date: Thu, 15 Apr 2004 13:38:45 -0700	[thread overview]
Message-ID: <20040415133845.T22989@build.pdx.osdl.net> (raw)
In-Reply-To: <407EEF6C.6030408@colorfullife.com>; from manfred@colorfullife.com on Thu, Apr 15, 2004 at 10:24:12PM +0200

* Manfred Spraul (manfred@colorfullife.com) wrote:
> Chris Wright wrote:
> >Patch below simply eats all leading slashes before passing name to
> >lookup_one_len() in mq_open() and mq_unlink().
> >
> Why should we do that in kernel space?
> The kernel interface is "no slash at all". User space can add a SuS 
> compatible layer on top of the kernel interface (i.e. fail with -EINVAL 
> if the first character is not a /, then skip the slash and pass "name+1" 
> to sys_mq_open()).

Jakub said similar, and I missed the fact that glibc was sanitizing
before calling kernel.  I agree, it's fine as is.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net

      reply	other threads:[~2004-04-15 20:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-15 18:39 [PATCH] mq_open() honor leading slash Chris Wright
2004-04-15 19:27 ` Jakub Jelinek
2004-04-15 20:02   ` Chris Wright
2004-04-15 20:24 ` Manfred Spraul
2004-04-15 20:38   ` Chris Wright [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040415133845.T22989@build.pdx.osdl.net \
    --to=chrisw@osdl.org \
    --cc=akpm@osdl.org \
    --cc=drepper@redhat.com \
    --cc=jakub@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manfred@colorfullife.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.