From: Christoph Hellwig <hch@infradead.org>
To: Bob Tracy <rct@gherkin.frus.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] sym53c500_cs PCMCIA SCSI driver (new)
Date: Fri, 16 Apr 2004 13:05:48 +0100 [thread overview]
Message-ID: <20040416130548.B5080@infradead.org> (raw)
In-Reply-To: <20040410021703.946A9DBE3@gherkin.frus.com>; from rct@gherkin.frus.com on Fri, Apr 09, 2004 at 09:17:03PM -0500
On Fri, Apr 09, 2004 at 09:17:03PM -0500, Bob Tracy wrote:
> The attached patch set implements a PCMCIA SCSI driver for host adapters
> based on the Symbios 53c500 chip. The original driver for this chip was
> written by Thomas Corner and available only as an add-on to the
> pcmcia-cs package. I've been maintaining the add-on driver on an
> infrequent basis for the past several years, and the release of the 2.6
> kernel "forced" a long overdue update.
>
> The only host adapter I'm aware of that uses the sym53c500 controller
> chip is the "new" version of the New Media Bus Toaster (circa 1996),
> and the attached driver has been tested using this particular adapter
> on a 2.6.4 kernel. The patch set applies cleanly to 2.6.4 and 2.6.5.
>
> Comments / feedback / cheers / jeers accepted...
I've given it a short spin and here's a bunch of comments:
- the split into three source files is supserflous, one file should do it
- please don't use host.h or scsi.h from drivers/scsi/. The defintions
not present in include/scsi/ are deprecated and shall not be used (the
most prominent example in your driver are the Scsi_<Foo> typedefs that
have been replaced by struct scsi_foo
- the driver doesn't even try to deal with multiple HBAs
- your detection logic could be streamlined a little, e.g. the request/release
resource mess
next prev parent reply other threads:[~2004-04-16 12:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-10 2:17 [PATCH] sym53c500_cs PCMCIA SCSI driver (new) Bob Tracy
2004-04-16 12:05 ` Christoph Hellwig [this message]
2004-04-16 14:17 ` Bob Tracy
2004-04-17 9:45 ` Christoph Hellwig
2004-04-20 16:11 ` [PATCH] sym53c500_cs PCMCIA SCSI driver (second round) Bob Tracy
2004-04-20 16:24 ` Christoph Hellwig
2004-04-25 3:01 ` [PATCH] sym53c500_cs PCMCIA SCSI driver (round 3 - the charm?) Bob Tracy
2004-04-25 7:36 ` Russell King
2004-04-25 21:26 ` Bob Tracy
2004-04-25 21:33 ` Russell King
2004-04-25 22:59 ` Bob Tracy
2004-04-25 14:34 ` Christoph Hellwig
2004-04-25 21:58 ` [PATCH] sym53c500_cs PCMCIA SCSI driver (round 4) Bob Tracy
2004-04-22 19:38 ` [PATCH] sym53c500_cs PCMCIA SCSI driver (new) Bill Davidsen
2004-04-22 20:48 ` Bob Tracy
-- strict thread matches above, loose matches on Subject: below --
2004-04-16 22:42 P. Christeas
2004-04-17 2:12 ` Bob Tracy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040416130548.B5080@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rct@gherkin.frus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.