From: Dave Jones <davej@redhat.com>
To: viro@parcelfarce.linux.theplanet.co.uk
Cc: jgarzik@pobox.com, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: baycom_par dereference before check.
Date: Fri, 16 Apr 2004 22:27:38 +0100 [thread overview]
Message-ID: <20040416212738.GQ20937@redhat.com> (raw)
In-Reply-To: <20040416212541.GH24997@parcelfarce.linux.theplanet.co.uk>
On Fri, Apr 16, 2004 at 10:25:41PM +0100, viro@parcelfarce.linux.theplanet.co.uk wrote:
> > +++ linux-2.6.5/drivers/net/hamradio/baycom_par.c 2004-04-16 22:19:33.000000000 +0100
> > @@ -272,9 +272,13 @@
> > static void par96_interrupt(int irq, void *dev_id, struct pt_regs *regs)
> > {
> > struct net_device *dev = (struct net_device *)dev_id;
> > - struct baycom_state *bc = netdev_priv(dev);
> > + struct baycom_state *bc;
> >
> > - if (!dev || !bc || bc->hdrv.magic != HDLCDRV_MAGIC)
> > + if (!dev)
> > + return;
> > +
> > + bc = netdev_priv(dev);
>
> That's OK - netdev_priv(p) just adds a constant offset to p; no problem
> with doing that to NULL.
Good point. Still doesn't strike me as particularly nice though.
Dave
next prev parent reply other threads:[~2004-04-16 21:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-16 21:20 baycom_par dereference before check Dave Jones
2004-04-16 21:25 ` viro
2004-04-16 21:27 ` Dave Jones [this message]
2004-04-16 21:48 ` Jeff Garzik
2004-04-16 21:53 ` Dave Jones
2004-04-16 23:07 ` Chris Wright
2004-04-16 23:40 ` Jeff Garzik
2004-04-19 16:39 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040416212738.GQ20937@redhat.com \
--to=davej@redhat.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.