From: Dave Jones <davej@redhat.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: viro@parcelfarce.linux.theplanet.co.uk,
Linus Torvalds <torvalds@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
bfennema@falcon.csc.calpoly.edu
Subject: Re: Fix UDF-FS potentially dereferencing null
Date: Sat, 17 Apr 2004 00:18:23 +0100 [thread overview]
Message-ID: <20040416231823.GZ20937@redhat.com> (raw)
In-Reply-To: <40806880.1030007@pobox.com>
On Fri, Apr 16, 2004 at 07:13:04PM -0400, Jeff Garzik wrote:
> >Check in question is a BS - it never gets NULL passed as dir.
>
> Yes, it looks like a lot of these NULL checks caught can be fixed simply
> by removing bogus and/or redundant checks.
And there's a *lot* of them. Those half dozen or so patches earlier were
results of just a quick random skim of the list the coverity folks came up with.
It'll take a lot of effort to 'fix' them all, and given the non-severity
of a lot of them, I'm not convinced it's worth the effort.
Some of them are obvious bugs (like the edd patches), but others are
a little less obvious, and thats where a lot of time can be wasted.
I've lost motivation to dig further for the time being. Maybe later.
Dave
next prev parent reply other threads:[~2004-04-16 23:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-16 21:41 Fix UDF-FS potentially dereferencing null Dave Jones
2004-04-16 21:58 ` Linus Torvalds
2004-04-16 22:00 ` viro
2004-04-16 23:13 ` Jeff Garzik
2004-04-16 23:18 ` Dave Jones [this message]
2004-04-16 23:34 ` viro
2004-04-17 0:44 ` Linus Torvalds
2004-04-17 9:50 ` Arjan van de Ven
2004-04-17 10:42 ` Arjan van de Ven
2004-04-17 11:12 ` Ingo Oeser
2004-04-17 17:14 ` Linus Torvalds
2004-04-22 20:29 ` Alexandre Oliva
2004-04-22 20:56 ` Linus Torvalds
2004-04-23 14:00 ` Alexandre Oliva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040416231823.GZ20937@redhat.com \
--to=davej@redhat.com \
--cc=bfennema@falcon.csc.calpoly.edu \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.