From: Olaf Hering <olh@suse.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [Fwd: [PATCH] ppc64: Fix CPU hot unplug deadlock]
Date: Sun, 18 Apr 2004 18:50:55 +0200 [thread overview]
Message-ID: <20040418165055.GC28807@suse.de> (raw)
In-Reply-To: <1082266724.2500.327.camel@gaston>
On Sun, Apr 18, Benjamin Herrenschmidt wrote:
> My RTAS locking fixes incorrectly added a spinlock around the function
> used to stop a CPU, that function never returns, thus the lock becomes
> stale. The correct fix is to disable interrupts instead (the RTAS params
> beeing per-CPU, this should be safe enough)
>
> Ben.
>
> diff -urN linux-2.5/arch/ppc64/kernel/rtas.c ppc64-linux-2.5/arch/ppc64/kernel/rtas.c
> --- linux-2.5/arch/ppc64/kernel/rtas.c 2004-04-17 12:39:03.253986984 +1000
> +++ ppc64-linux-2.5/arch/ppc64/kernel/rtas.c 2004-04-18 15:35:41.871029480 +1000
> @@ -504,9 +504,9 @@
> void rtas_stop_self(void)
> {
> struct rtas_args *rtas_args = &(get_paca()->xRtas);
> - unsigned long s;
>
> - spin_lock_irqsave(&rtas.lock, s);
> + local_irq_disable(s);
did that compile ok for you?
--
USB is for mice, FireWire is for men!
sUse lINUX ag, nÜRNBERG
next parent reply other threads:[~2004-04-18 16:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1082266724.2500.327.camel@gaston>
2004-04-18 16:50 ` Olaf Hering [this message]
2004-04-18 22:45 ` [Fwd: [PATCH] ppc64: Fix CPU hot unplug deadlock] Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040418165055.GC28807@suse.de \
--to=olh@suse.de \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.