Re: [uml-devel] Re: [PATCH] Fix for annoying problem with hostfs readdir problems.

[Oleg Drokin <green@linuxhacker.ru>]

Hello!

On Sun, Apr 18, 2004 at 05:26:23PM +0200, BlaisorBlade wrote:
> > >    So the annoying problem with readdir not working on hostfs (on 2.6
> > > host kernel only for me) was finally hunted to memory allocation
> > >    problem during opendir.
> I've experienced it too onto 2.6 and someone else had the same problem - but 
> that patch is not perfect. Using always vmalloc() instead of kmalloc() is 
> wrong - vmalloc is slower, and Linus spoke against vmalloc(); it would also 
> slow down everything using malloc().

Well, speed is not of much an issue there, that function is only used for
glibc allocations. And that read_dir() is probably the only place that
causes glibc to allocate something.

> Probably you should use vmalloc() only if size is > the size limit (if this is 
> the problem, as I guess). When you come at free() it is a bit hard, but IIRC 
> vmalloc() can return pointers inside a certain, known memory area, right? So 
> it is possible to understand what function to call.

I am sure that all of the complexity you propose to implement won't pay off in
the end.

Bye,
    Oleg


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel