From: Andreas Jochens <aj@andaco.de>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: "David S. Miller" <davem@redhat.com>, linux-kernel@vger.kernel.org
Subject: [PATCH] tg3 driver - address error in TSO firmware code
Date: Mon, 19 Apr 2004 20:12:38 +0200 [thread overview]
Message-ID: <20040419181238.GA5987@andaco.de> (raw)
In-Reply-To: <4083F5CE.5080008@pobox.com>
On 04-Apr-19 11:52, Jeff Garzik wrote:
> It's still a patch for more political purposes than technical ones.
Of course you are right. However, the main purpose of posting my
patches was _not_ to get them into the mainline kernel but
to get feedback regarding the technical possibility of using the driver
without the firmware. I got some private mails confirming that the
patched driver works for different controllers without the firmware.
While looking at the tg3.c sources I found the attached problem.
Regards
Andreas Jochens
diff -urN linux-2.6.5.orig/drivers/net/tg3.c linux-2.6.5/drivers/net/tg3.c
--- linux-2.6.5.orig/drivers/net/tg3.c 2004-04-03 21:37:23.000000000 -0600
+++ linux-2.6.5/drivers/net/tg3.c 2004-04-19 12:47:09.254148712 -0500
@@ -3842,7 +3842,7 @@
#define TG3_TSO_FW_START_ADDR 0x08000000
#define TG3_TSO_FW_TEXT_ADDR 0x08000000
#define TG3_TSO_FW_TEXT_LEN 0x1a90
-#define TG3_TSO_FW_RODATA_ADDR 0x08001a900
+#define TG3_TSO_FW_RODATA_ADDR 0x08001a90
#define TG3_TSO_FW_RODATA_LEN 0x60
#define TG3_TSO_FW_DATA_ADDR 0x08001b20
#define TG3_TSO_FW_DATA_LEN 0x20
next prev parent reply other threads:[~2004-04-19 18:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-18 13:55 [PATCH] tg3 driver - make use of binary-only firmware optional Andreas Jochens
2004-04-18 21:02 ` walt
2004-04-19 1:08 ` David S. Miller
2004-04-19 8:04 ` Andreas Jochens
2004-04-19 8:58 ` Wichert Akkerman
2004-04-19 15:41 ` Andreas Jochens
2004-04-19 15:49 ` Jeff Garzik
2004-04-19 15:52 ` Jeff Garzik
2004-04-19 18:12 ` Andreas Jochens [this message]
2004-04-19 18:25 ` [PATCH] tg3 driver - address error in TSO firmware code David S. Miller
2004-04-19 18:32 ` Jeff Garzik
2004-04-19 18:33 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040419181238.GA5987@andaco.de \
--to=aj@andaco.de \
--cc=davem@redhat.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.