From: Pavel Machek <pavel@ucw.cz>
To: Andi Kleen <ak@muc.de>
Cc: "Tomar, Nagendra" <nagendra_tomar@adaptec.com>,
linux-kernel@vger.kernel.org
Subject: Re: why change_page_attr on x86 uses __flush_tlb_all
Date: Tue, 20 Apr 2004 15:03:53 +0200 [thread overview]
Message-ID: <20040420130353.GC831@openzaurus.ucw.cz> (raw)
In-Reply-To: <m3smf5ic38.fsf@averell.firstfloor.org>
Hi!
> > I would expect __flush_tlb_one (for each page) as a better choice.
> > It'll be nice if someone can hoghlight on why __flush_tlb_all is used.
> > The kernel version I am referring from is 2.4.18-14
>
> This works around a bug in some early Athlons with flushing global
> large pages. Also it makes the code slightly simpler and change_page_attr
> is not really performance critical.
Perhaps comment should be added? Otherwise someone is going
to "fix" it sooner or later.
--
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms
next prev parent reply other threads:[~2004-04-22 19:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1Lek1-5lB-3@gated-at.bofh.it>
2004-04-15 13:51 ` why change_page_attr on x86 uses __flush_tlb_all Andi Kleen
2004-04-20 13:03 ` Pavel Machek [this message]
2004-04-15 12:32 Nagendra Singh Tomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040420130353.GC831@openzaurus.ucw.cz \
--to=pavel@ucw.cz \
--cc=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
--cc=nagendra_tomar@adaptec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.