From: Willy Tarreau <w@w.ods.org>
To: William Lee Irwin III <wli@holomorphy.com>,
Marcelo Tosatti <marcelo@hera.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: linux-2.4.26 released
Date: Wed, 21 Apr 2004 06:53:44 +0200 [thread overview]
Message-ID: <20040421045344.GJ596@alpha.home.local> (raw)
In-Reply-To: <20040420232312.GQ743@holomorphy.com>
Hi William,
On Tue, Apr 20, 2004 at 04:23:12PM -0700, William Lee Irwin III wrote:
> - return (mps_cpu/4)*16 + (1<<(mps_cpu%4));
> + return (mps_cpu & ~0x3) << 2 | 1 << (mps_cpu & 0x3);
^^^^
I think you wanted to put '<< 4' here instead of '<< 2'. Also, could you
put (useless for some) parenthesis to group the left side and the right
side of the bit-wise OR ? I'm always scared that someone changes it to
an addition with good intentions and changes the operators precedence
without noticing.
Cheers,
Willy
next prev parent reply other threads:[~2004-04-21 4:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-14 13:14 linux-2.4.26 released Marcelo Tosatti
2004-04-20 23:23 ` William Lee Irwin III
2004-04-21 4:53 ` Willy Tarreau [this message]
2004-04-21 8:25 ` Axel Weiß
2004-04-21 10:12 ` William Lee Irwin III
2004-04-21 10:42 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040421045344.GJ596@alpha.home.local \
--to=w@w.ods.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@hera.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.