From: "David S. Miller" <davem@redhat.com>
To: Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua>
Cc: jmorris@redhat.com, jgarzik@pobox.com, linux-kernel@vger.kernel.org
Subject: Re: Large inlines in include/linux/skbuff.h
Date: Thu, 22 Apr 2004 11:36:45 -0700 [thread overview]
Message-ID: <20040422113645.19208a70.davem@redhat.com> (raw)
In-Reply-To: <200404221756.46240.vda@port.imtp.ilyichevsk.odessa.ua>
On Thu, 22 Apr 2004 17:56:46 +0300
Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua> wrote:
> On Thursday 22 April 2004 03:47, James Morris wrote:
> > On Wed, 21 Apr 2004, Denis Vlasenko wrote:
> > > What shall be done with this? I'll make patch to move locking functions
> > > into net/core/skbuff.c unless there is some reason not to do it.
> >
> > How will these changes impact performance? I asked this last time you
> > posted about inlines and didn't see any response.
>
> Hard to say. We will lose ~2% to extra call/return instructions
> but will gain 40kb of icache space.
He's asking you to test and quantify the performance changes that
occur as a result of this patch, not to figure it out via calculations
in your head :-)
next prev parent reply other threads:[~2004-04-22 18:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-21 19:26 Large inlines in include/linux/skbuff.h Denis Vlasenko
2004-04-22 0:47 ` James Morris
[not found] ` <200404221756.46240.vda@port.imtp.ilyichevsk.odessa.ua>
2004-04-22 18:36 ` David S. Miller [this message]
[not found] ` <200404222239.34760.vda@port.imtp.ilyichevsk.odessa.ua>
2004-04-22 22:10 ` David S. Miller
2004-04-27 21:21 ` [PATCH] eliminate large inline's in skbuff Stephen Hemminger
2004-04-27 23:30 ` David S. Miller
[not found] ` <200405020037.47712.vda@port.imtp.ilyichevsk.odessa.ua>
2004-05-05 21:59 ` Stephen Hemminger
2004-05-06 17:13 ` Denis Vlasenko
[not found] <1NvJL-1QO-9@gated-at.bofh.it>
[not found] ` <1NAJr-61F-3@gated-at.bofh.it>
2004-04-22 14:59 ` Large inlines in include/linux/skbuff.h Andi Kleen
2004-04-22 15:15 ` James Morris
2004-04-22 15:37 ` Eric Dumazet
[not found] ` <200404221927.34717.vda@port.imtp.ilyichevsk.odessa.ua>
2004-04-22 19:24 ` Eric Dumazet
2004-04-22 22:23 ` Andi Kleen
2004-04-22 22:25 ` David S. Miller
2004-04-22 22:34 ` Andi Kleen
2004-04-22 22:35 ` David S. Miller
[not found] ` <1NRqX-2GI-15@gated-at.bofh.it>
[not found] ` <1NRqX-2GI-13@gated-at.bofh.it>
2004-04-22 19:51 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040422113645.19208a70.davem@redhat.com \
--to=davem@redhat.com \
--cc=jgarzik@pobox.com \
--cc=jmorris@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vda@port.imtp.ilyichevsk.odessa.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.