From: Jeremy Higdon <jeremy@sgi.com>
To: jgarzik@pobox.com, linux-scsi@vger.kernel.org
Subject: [PATCH] sata_vsc initialization fix
Date: Thu, 22 Apr 2004 19:15:44 -0700 [thread overview]
Message-ID: <20040423021544.GA874976@sgi.com> (raw)
I neglected to initialize a couple of registers that are usually
zero, but not always. :-)
Please apply.
jeremy
# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.1783 -> 1.1784
# drivers/scsi/sata_vsc.c 1.6 -> 1.7
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 04/04/22 jeremy@tomahawk.engr.sgi.com 1.1784
# Fix sata_vsc to initialize upper address pointer registers.
# --------------------------------------------
#
diff -Nru a/drivers/scsi/sata_vsc.c b/drivers/scsi/sata_vsc.c
--- a/drivers/scsi/sata_vsc.c Thu Apr 22 19:14:14 2004
+++ b/drivers/scsi/sata_vsc.c Thu Apr 22 19:14:14 2004
@@ -44,6 +44,8 @@
#define VSC_SATA_TF_CTL_OFFSET 0x29
/* DMA base */
+#define VSC_SATA_UP_DESCIPTOR_OFFSET 0x64
+#define VSC_SATA_UP_DATA_BUFFER_OFFSET 0x6C
#define VSC_SATA_DMA_CMD_OFFSET 0x70
/* SCRs base */
@@ -234,6 +236,8 @@
port->ctl_addr = base + VSC_SATA_TF_CTL_OFFSET;
port->bmdma_addr = base + VSC_SATA_DMA_CMD_OFFSET;
port->scr_addr = base + VSC_SATA_SCR_STATUS_OFFSET;
+ writel(0, base + VSC_SATA_UP_DESCIPTOR_OFFSET);
+ writel(0, base + VSC_SATA_UP_DATA_BUFFER_OFFSET);
}
next reply other threads:[~2004-04-23 2:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-23 2:15 Jeremy Higdon [this message]
2004-04-23 18:08 ` [PATCH] sata_vsc initialization fix Jeremy Higdon
2004-04-25 2:16 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040423021544.GA874976@sgi.com \
--to=jeremy@sgi.com \
--cc=jgarzik@pobox.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.