From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Kirch Subject: Re: [PATCH] Reinstantiating stale inodes Date: Fri, 23 Apr 2004 19:55:52 +0200 Sender: nfs-admin@lists.sourceforge.net Message-ID: <20040423175552.GA13755@suse.de> References: <40892507.2030004@RedHat.com> <20040423143308.GW3491@suse.de> <40893B51.2080302@RedHat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: nfs@lists.sourceforge.net Return-path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.12] helo=sc8-sf-mx2.sourceforge.net) by sc8-sf-list2.sourceforge.net with esmtp (Exim 4.30) id 1BH4u5-0004KI-8d for nfs@lists.sourceforge.net; Fri, 23 Apr 2004 10:55:57 -0700 Received: from ns.suse.de ([195.135.220.2] helo=Cantor.suse.de) by sc8-sf-mx2.sourceforge.net with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.30) id 1BH4u4-0001Nz-PR for nfs@lists.sourceforge.net; Fri, 23 Apr 2004 10:55:56 -0700 To: Steve Dickson In-Reply-To: <40893B51.2080302@RedHat.com> Errors-To: nfs-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: Discussion of NFS under Linux development, interoperability, and testing. List-Post: List-Help: List-Subscribe: , List-Archive: On Fri, Apr 23, 2004 at 11:50:41AM -0400, Steve Dickson wrote: > client: writes 100m file called foo > server: renames foo to foo.old and immediately creates foo > client: failed with ESTALE This shouldn't fail, because the file still exists, just under a different name. What will get you into trouble is if your client writes to "foo" and you do a "mv bar foo". > Again only getattrs will be followed up with lookups.. Yes, but it's just a matter of probabilities if the first call that returns ESTALE is a write or a getattr (called from revalidate_inode). > >At a minimum, the lookup should occur at file open, and only if > >there are no other users of the inode. > > > > > Unfortunately, in this particular case, there were no opens... So what exactly went wrong? A stat() on the files that just got replaced? Olaf -- Olaf Kirch | The Hardware Gods hate me. okir@suse.de | ---------------+ ------------------------------------------------------- This SF.net email is sponsored by: The Robotic Monkeys at ThinkGeek For a limited time only, get FREE Ground shipping on all orders of $35 or more. Hurry up and shop folks, this offer expires April 30th! http://www.thinkgeek.com/freeshipping/?cpg=12297 _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs