From mboxrd@z Thu Jan 1 00:00:00 1970 From: Domen Puncer Date: Sun, 25 Apr 2004 22:46:07 +0000 Subject: Re: [Kernel-janitors] [PATCH] - Replaces yield() with Message-Id: <20040425224607.GF1394@masina> MIME-Version: 1 Content-Type: multipart/mixed; boundary="===============56991888024783566==" List-Id: References: <407C9AEE.5020808@legolas.alternex.com.br> In-Reply-To: <407C9AEE.5020808@legolas.alternex.com.br> To: kernel-janitors@vger.kernel.org --===============56991888024783566== Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Apr 25, 2004 at 07:13:53PM -0300, Gustavo Franco wrote: > Domen Puncer wrote: > > >... > > > > > >>| >| --- drivers/cdrom/cdu31a.c.orig 2004-04-13 22:43:55.000000000 -0300 > >>| >| +++ drivers/cdrom/cdu31a.c 2004-04-13 22:44:17.000000000 -0300 > >>| >| @@ -386,7 +386,7 @@ static inline void sony_sleep(void) > >>| >| unsigned long flags; > >>| >| > >>| >| > >>| >| if (cdu31a_irq <= 0) { > >>| >| - yield(); > >>| >| + schedule_timeout(1); > >> > >> > > > >set_current_state() missing. > > > > > Are you talking about something like: > > set_current_state(TASK_UNINTERRUPTIBLE); > schedule_timeout(1); > > Is is really necessary? Yes, comment above schedule_timeout: * Make the current task sleep until @timeout jiffies have * elapsed. The routine will return immediately unless * the current task state has been set (see set_current_state()). ...the "immediately" part > > Thanks, > Gustavo Franco -- --===============56991888024783566== Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline _______________________________________________ Kernel-janitors mailing list Kernel-janitors@lists.osdl.org http://lists.osdl.org/mailman/listinfo/kernel-janitors --===============56991888024783566==--