All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Jackson <pj@sgi.com>
To: Andrew Morton <akpm@osdl.org>, John Reiser <jreiser@BitWagon.com>,
	mike@navi.cx, pageexec@freemail.hu
Cc: linux-kernel@vger.kernel.org
Subject: arch/ia64/ia32/binfmt_elf32.c: elf32_map() broken ia64 build
Date: Mon, 26 Apr 2004 18:56:33 -0700	[thread overview]
Message-ID: <20040426185633.7969ca0d.pj@sgi.com> (raw)

Not sure how (no lkml thread that I can see), but it seems from Andrew's
broken out patch "bssprot.patch" in 2.6.6-rc2-mm2 that John Reiser
and/or others on the To list above conspired to break the build of
arch/ia64/ia32/binfmt_elf32.c: elf32_map().

They added a patch that amongst other things, did:

- elf_map(): new parameter total_size allows for holes between PT_LOAD; in
  fs/binfmt_elf.c, arch/x86_64/ia32/ia32_binfmt.c, arch/s390/kernel/
  binfmt_elf32.c.

but they didn't change (note elf32_map is just elf_map, via a #define) this:


===== arch/ia64/ia32/binfmt_elf32.c 1.22 vs edited =====
223c223
< elf32_map (struct file *filep, unsigned long addr, struct elf_phdr *eppnt, int prot, int type)
---
> elf32_map (struct file *filep, unsigned long addr, struct elf_phdr const *eppnt, int prot, int type, unsigned long total_size)


If I make the above function signature change, I can at least recompile
arch ia64 with CONFIG_IA32_SUPPORT enabled.  But I doubt that this is
ideal - as it is making no use of the new 'total_size' parameter.

Would someone care to recommend a proper fix?

-- 
                          I won't rest till it's the best ...
                          Programmer, Linux Scalability
                          Paul Jackson <pj@sgi.com> 1.650.933.1373

             reply	other threads:[~2004-04-27  1:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-27  1:56 Paul Jackson [this message]
2004-04-27  5:17 ` arch/ia64/ia32/binfmt_elf32.c: elf32_map() broken ia64 build John Reiser
2004-04-27  5:27   ` Paul Jackson
2004-05-01  8:33 ` Paul Jackson
2004-05-01  8:33   ` arch/ia64/ia32/binfmt_elf32.c: elf32_map() broken ia64 build _and_ boot Paul Jackson
2004-05-03 14:08   ` arch/ia64/ia32/binfmt_elf32.c: elf32_map() broken ia64 build John Reiser
2004-05-03 14:08     ` arch/ia64/ia32/binfmt_elf32.c: elf32_map() broken ia64 build _and_ boot John Reiser
2004-05-03 17:57     ` arch/ia64/ia32/binfmt_elf32.c: elf32_map() broken ia64 build Andrew Morton
2004-05-03 17:57       ` arch/ia64/ia32/binfmt_elf32.c: elf32_map() broken ia64 build _and_ boot Andrew Morton
2004-05-03 21:04     ` arch/ia64/ia32/binfmt_elf32.c: elf32_map() broken ia64 build Paul Jackson
2004-05-03 21:04       ` arch/ia64/ia32/binfmt_elf32.c: elf32_map() broken ia64 build _and_ boot Paul Jackson
2004-05-03 21:29       ` arch/ia64/ia32/binfmt_elf32.c: elf32_map() broken ia64 build Mike Hearn
2004-05-03 21:29         ` arch/ia64/ia32/binfmt_elf32.c: elf32_map() broken ia64 build _and_ boot Mike Hearn
2004-05-03 22:10         ` arch/ia64/ia32/binfmt_elf32.c: elf32_map() broken ia64 build Paul Jackson
2004-05-03 22:10           ` arch/ia64/ia32/binfmt_elf32.c: elf32_map() broken ia64 build _and_ boot Paul Jackson
2004-05-03 22:20           ` arch/ia64/ia32/binfmt_elf32.c: elf32_map() broken ia64 build Mike Hearn
2004-05-03 22:20             ` arch/ia64/ia32/binfmt_elf32.c: elf32_map() broken ia64 build _and_ boot Mike Hearn
2004-05-03 22:26             ` arch/ia64/ia32/binfmt_elf32.c: elf32_map() broken ia64 build Paul Jackson
2004-05-03 22:26               ` arch/ia64/ia32/binfmt_elf32.c: elf32_map() broken ia64 build _and_ boot Paul Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040426185633.7969ca0d.pj@sgi.com \
    --to=pj@sgi.com \
    --cc=akpm@osdl.org \
    --cc=jreiser@BitWagon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike@navi.cx \
    --cc=pageexec@freemail.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.