From: Greg KH <greg@kroah.com>
To: Michael Brown <Michael_E_Brown@Dell.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, mebrown@michaels-house.net
Subject: Re: [BK PATCH] add SMBIOS tables to sysfs
Date: Tue, 27 Apr 2004 20:30:20 -0700 [thread overview]
Message-ID: <20040428033020.GA14078@kroah.com> (raw)
In-Reply-To: <1083119269.1203.2821.camel@debian>
On Tue, Apr 27, 2004 at 09:27:49PM -0500, Michael Brown wrote:
> Andrew,
> Below is a short patch to add SMBIOS data to sysfs. It it against latest
> bitkeeper 2.6.6-rc (specifically, it applies after the efivars patch that
> recently went in) but should apply to any recent kernel with only minor
> reject on drivers/firmware/Makefile. A version for 2.4 (using /proc) will
> follow tomorrow.
Nice idea and patch. A few minor comments:
> /sys/firmware/smbios/smbios/table_entry_point
> /sys/firmware/smbios/smbios/table
Why repeat the "smbios" directory? Is this a limitation in the sysfs
interface right now? Or are you going to put more files in the main
smbios directory some day?
> + snprintf(sdev->kobj.name, 7, "smbios" );
Try using kobject_set_name() instead, it will do the proper thing if the
string is bigger than the base kobj.name field.
thanks,
greg k-h
next prev parent reply other threads:[~2004-04-28 3:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-28 2:27 [BK PATCH] add SMBIOS tables to sysfs Michael Brown
2004-04-28 3:30 ` Greg KH [this message]
2004-04-28 3:38 ` Michael Brown
2004-04-28 16:50 ` Greg KH
2004-04-28 3:55 ` Michael Brown
2004-04-28 16:51 ` Greg KH
2004-04-28 4:41 ` [BK PATCH] add SMBIOS tables to sysfs -- UPDATED Michael Brown
-- strict thread matches above, loose matches on Subject: below --
2004-04-28 17:18 [BK PATCH] add SMBIOS tables to sysfs Michael_E_Brown
2004-04-28 17:36 ` Greg KH
2004-04-28 17:37 Michael_E_Brown
2004-04-28 17:44 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040428033020.GA14078@kroah.com \
--to=greg@kroah.com \
--cc=Michael_E_Brown@Dell.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mebrown@michaels-house.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.