From: Tim Hockin <thockin@sun.com>
To: viro@parcelfarce.linux.theplanet.co.uk
Cc: Linux Kernel mailing list <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@osdl.org>
Subject: Re: BUG: might_sleep in /proc/swaps code
Date: Thu, 29 Apr 2004 12:22:09 -0700 [thread overview]
Message-ID: <20040429192209.GF1483@sun.com> (raw)
In-Reply-To: <20040429020309.GF17014@parcelfarce.linux.theplanet.co.uk>
On Thu, Apr 29, 2004 at 03:03:09AM +0100, viro@parcelfarce.linux.theplanet.co.uk wrote:
> OK, here comes. New semaphore protecting insertions/removals in the
> set of swap components + switch of ->start()/->stop() to the same
> semaphore [fixes deadlocks] + trivial cleanup of ->next().
>
> See if it works for you...
Well, it stops bitching about might_sleep(), so it solves the obvious
problems. I'm not in a position to comment about the other complexities of
swapfile.c, so I'll take it on faith that you got it right. :)
Thanks
Tim
prev parent reply other threads:[~2004-04-29 19:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-28 23:24 BUG: might_sleep in /proc/swaps code Tim Hockin
2004-04-29 0:53 ` viro
2004-04-29 2:03 ` viro
2004-04-29 19:22 ` Tim Hockin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040429192209.GF1483@sun.com \
--to=thockin@sun.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.