From: Greg Banks <gnb@sgi.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Olaf Kirch <okir@suse.de>, nfs@lists.sourceforge.net
Subject: Re: Marking inodes as stale can be wrong
Date: Fri, 30 Apr 2004 09:50:18 +1000 [thread overview]
Message-ID: <20040429235018.GC4843@sgi.com> (raw)
In-Reply-To: <1083258570.3686.38.camel@lade.trondhjem.org>
On Thu, Apr 29, 2004 at 01:09:30PM -0400, Trond Myklebust wrote:
> On Thu, 2004-04-29 at 12:58, Olaf Kirch wrote:
> > On Thu, Apr 29, 2004 at 12:44:56PM -0400, Trond Myklebust wrote:
> > > On Thu, 2004-04-29 at 10:40, Olaf Kirch wrote:
> > > > fh_verify did the subtree check, and found that
> > > > ~/Mail was mode 700, and hence user nobody didn't
> > > > have x permissions on the directory. So it would
> > > > return ESTALE to the client.
> > >
> > > This is a bug!
> >
> > Yes, probably. Even though I'm not entirely sure NFSERR_ACCES is a valid
> > return for all NFS operations.
>
> The problem is that Neil is using NFSERR_STALE as a standin for
> NFSERR_ACCES precisely because the latter is not on the list of accepted
> return value for GETATTR in RFC1813.
> IMO this is *worse* behaviour than just returning the non-rfc compatible
> error.
FWIW there's a little known sentence in RFC1813 Section 3 which says
> The ERRORS section lists the errors returned for specific types of
> failures. These lists are not intended to be the definitive statement
> of all of the errors which can be returned by any specific procedure,
> but as a guide for the more common errors which may be returned.
This has been interpreted in discussions here as a loophole that allows
the server to return any of the defined NFS errors for any of the calls
at its discretion.
I don't know why the server returns NFSERR_STALE instead of NFSERR_ACCES,
but RFC compliance is not a good reason.
Greg.
--
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
I don't speak for SGI.
-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g.
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
next prev parent reply other threads:[~2004-04-29 23:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-29 14:40 Marking inodes as stale can be wrong Olaf Kirch
2004-04-29 16:44 ` Trond Myklebust
2004-04-29 16:58 ` Olaf Kirch
2004-04-29 17:09 ` Trond Myklebust
2004-04-29 21:28 ` Olaf Kirch
2004-04-29 23:50 ` Greg Banks [this message]
2004-04-30 0:43 ` Trond Myklebust
2004-04-30 1:51 ` Greg Banks
2004-04-30 8:34 ` Olaf Kirch
2004-04-30 8:47 ` Greg Banks
2004-04-30 8:58 ` Olaf Kirch
2004-04-29 17:21 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040429235018.GC4843@sgi.com \
--to=gnb@sgi.com \
--cc=nfs@lists.sourceforge.net \
--cc=okir@suse.de \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.