All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jack Steiner <steiner@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: BUG_ON(irqs_disabled()) in smp_call_function - cant boot
Date: Fri, 30 Apr 2004 14:44:54 +0000	[thread overview]
Message-ID: <20040430144454.GA8719@sgi.com> (raw)

There was a BUG_ON(irqs_disabled()) recently added to
smp_call_function(). 

This check is hit during boot. Looks like there is a vfree in
sg_add that is done with interrupts disabled. This trips the BUG_ON.

The check is valid, but I wonder how many other places will trip the bug
check.


Call Trace:
 [<a000000100019200>] show_stack+0x80/0xa0
 [<a0000001000402b0>] die+0x1d0/0x2a0
 [<a0000001000406d0>] ia64_bad_break+0x2f0/0x420
 [<a000000100011d80>] ia64_leave_kernel+0x0/0x270
 [<a00000010005d850>] smp_call_function+0x3b0/0x3c0
 [<a00000010005cc60>] smp_flush_tlb_all+0x40/0x80
 [<a00000010015b9f0>] unmap_vm_area+0xf0/0x120
 [<a00000010015c070>] remove_vm_area+0x150/0x1e0
 [<a00000010015c150>] __vunmap+0x50/0x1e0
 [<a0000002011ba5f0>] sg_add+0x2d0/0xbe0 [sg]
 [<a0000001004b4de0>] class_interface_register+0x1e0/0x2a0
 [<a00000010056bc30>] scsi_register_interface+0x30/0x60
 [<a00000020114c200>] init_sg+0x140/0x190 [sg]
 [<a0000001001159c0>] sys_init_module+0x3c0/0x660
 [<a000000100011be0>] ia64_ret_from_syscall+0x0/0x20



sg_add(struct class_device *cl_dev)
{
        write_lock_irqsave(&sg_dev_arr_lock, iflags);
        if (sg_nr_dev >= sg_dev_max) {  /* try to resize */
                write_unlock_irqrestore(&sg_dev_arr_lock, iflags);
                ...
                write_lock_irqsave(&sg_dev_arr_lock, iflags);
                ...
                vfree((char *) sg_dev_arr);                                                                                                               
        }                                                                                                                                                               
        ...
}

-- 
Thanks

Jack Steiner (steiner@sgi.com)          651-683-5302
Principal Engineer                      SGI - Silicon Graphics, Inc.



             reply	other threads:[~2004-04-30 14:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-30 14:44 Jack Steiner [this message]
2004-04-30 14:52 ` BUG_ON(irqs_disabled()) in smp_call_function - cant boot Keith Owens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040430144454.GA8719@sgi.com \
    --to=steiner@sgi.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.