From: Matt Domsch <Matt_Domsch@dell.com>
To: Jens Axboe <axboe@suse.de>, akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: reduce blk queue and I/O capability printk to KERN_DEBUG?
Date: Fri, 30 Apr 2004 16:28:37 -0500 [thread overview]
Message-ID: <20040430212837.GA9853@lists.us.dell.com> (raw)
In-Reply-To: <20040430211342.GA31842@suse.de>
[-- Attachment #1: Type: text/plain, Size: 1220 bytes --]
On Fri, Apr 30, 2004 at 11:13:43PM +0200, Jens Axboe wrote:
> It should just be deleted. As you note, it is a debug message. I
> originally added it so we would have some clues as to dma capability for
> bug reports. There never was any, the check can go :)
OK, please ack the below for Andrew then.
Remove blk: queue xxxx I/O limit xxxx messages printed by all block devices
This was a debug message and is no longer needed.
===== drivers/block/ll_rw_blk.c 1.244 vs edited =====
--- 1.244/drivers/block/ll_rw_blk.c Tue Apr 27 08:11:32 2004
+++ edited/drivers/block/ll_rw_blk.c Fri Apr 30 16:24:03 2004
@@ -280,17 +280,6 @@
} else
q->bounce_gfp = GFP_NOIO;
- /*
- * keep this for debugging for now...
- */
- if (dma_addr != BLK_BOUNCE_HIGH && q != last_q) {
- printk("blk: queue %p, ", q);
- if (dma_addr == BLK_BOUNCE_ANY)
- printk("no I/O memory limit\n");
- else
- printk("I/O limit %luMb (mask 0x%Lx)\n", mb, (long long) dma_addr);
- }
-
q->bounce_pfn = bounce_pfn;
last_q = q;
}
--
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions linux.dell.com & www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-04-30 21:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-30 19:50 reduce blk queue and I/O capability printk to KERN_DEBUG? Matt Domsch
2004-04-30 21:13 ` Jens Axboe
2004-04-30 21:28 ` Matt Domsch [this message]
2004-04-30 21:44 ` Matt Domsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040430212837.GA9853@lists.us.dell.com \
--to=matt_domsch@dell.com \
--cc=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.