All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjanv@redhat.com>
To: Christoph Hellwig <hch@infradead.org>,
	linux-kernel@vger.kernel.org, B.Zolnierkiewicz@elka.pw.edu.pl,
	akpm@osdl.org
Subject: Re: Force IDE cache flush on shutdown
Date: Thu, 6 May 2004 13:45:44 +0200	[thread overview]
Message-ID: <20040506114544.GC16548@devserv.devel.redhat.com> (raw)
In-Reply-To: <20040506113309.GB16548@devserv.devel.redhat.com>


On Thu, May 06, 2004 at 01:33:09PM +0200, Arjan van de Ven wrote:
> On Thu, May 06, 2004 at 11:52:20AM +0100, Christoph Hellwig wrote:
> > > +	idedisk_driver.gen_driver.shutdown = ide_drive_shutdown;
> > 
> > isn't idedisk_driver initialized statically somewhere?  You should probably
> 
> ok ok you win
> 
> diff -purN linux-2.6.5/drivers/ide/ide-disk.c linux/drivers/ide/ide-disk.c
> --- linux-2.6.5/drivers/ide/ide-disk.c	2004-05-06 13:26:53.350284720 +0200
> +++ linux/drivers/ide/ide-disk.c	2004-05-06 13:32:01.322465832 +0200
> @@ -1725,6 +1725,9 @@ static ide_driver_t idedisk_driver = {
>  	.drives			= LIST_HEAD_INIT(idedisk_driver.drives),
>  	.start_power_step	= idedisk_start_power_step,
>  	.complete_power_step	= idedisk_complete_power_step,
> +	.gen_driver = {
> +		.shutdown	= ide_drive_shutdown,
> +	},	                                


and that needs a prototype as well 

--- linux-2.6.5/drivers/ide/ide-disk.c~	2004-05-06 13:44:41.052969240 +0200
+++ linux-2.6.5/drivers/ide/ide-disk.c	2004-05-06 13:44:41.053969088 +0200
@@ -1701,6 +1701,7 @@
 }
 
 static int idedisk_attach(ide_drive_t *drive);
+static int ide_drive_shutdown(struct device * dev);
 
 /*
  *      IDE subdriver functions, registered with ide.c

  parent reply	other threads:[~2004-05-06 11:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-06  7:04 Force IDE cache flush on shutdown Arjan van de Ven
2004-05-06  7:49 ` Christoph Hellwig
2004-05-06  7:50   ` Arjan van de Ven
2004-05-06  7:55     ` Christoph Hellwig
2004-05-06 10:46       ` Arjan van de Ven
2004-05-06 10:52         ` Christoph Hellwig
2004-05-06 11:33           ` Arjan van de Ven
2004-05-06 11:45             ` Nigel Cunningham
2004-05-06 11:45             ` Arjan van de Ven [this message]
2004-05-06 12:36             ` Bartlomiej Zolnierkiewicz
2004-05-07  1:08               ` Benjamin Herrenschmidt
2004-05-06 11:38   ` Bartlomiej Zolnierkiewicz
2004-05-07  1:09     ` Benjamin Herrenschmidt
2004-05-09  2:00   ` Pavel Machek
2004-05-06  7:58 ` Jens Axboe
2004-05-06  8:04   ` Arjan van de Ven
2004-05-06  8:05     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040506114544.GC16548@devserv.devel.redhat.com \
    --to=arjanv@redhat.com \
    --cc=B.Zolnierkiewicz@elka.pw.edu.pl \
    --cc=akpm@osdl.org \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.