All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel@metro.cx
To: linux-kernel@vger.kernel.org
Subject: USB gadgets, small bug
Date: Fri, 7 May 2004 14:02:02 +0200	[thread overview]
Message-ID: <20040507120202.GA9221@metro.cx> (raw)

Hi All,

I don't know where else to report this, but I found a very very very
minor bug in the usb gadgets drivers, specifically the file_storage.c
mass storage driver.

In the function do_request_sense(..) it says:

buf[7] = 18 - 7;                        // Additional sense length

Whereas (according to page 38 of the USB mass storage class, UFI command spec,
http://www.usb.org/developers/devclass_docs#approved) this clearly neads
to be equal to 10, not 11.

I checked with the 2.6.5 source, it is still there. Hope someone will find this usefull, although most USB hosts seem to ignore length bits alltogether anyway....

Koen Martens

-- 
http://www.sonologic.nl/

                 reply	other threads:[~2004-05-07 12:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040507120202.GA9221@metro.cx \
    --to=kernel@metro.cx \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.