From: Jan-Benedict Glaw <jbglaw@lug-owl.de>
To: Michael Westermann <mw@microdata-pos.de>,
"Theodore Y. Ts'o" <tytso@MIT.EDU>,
Rusty Russell <rusty@rustcorp.com.au>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] handshake variable with DTR DSR DCD ...
Date: Fri, 7 May 2004 20:11:14 +0200 [thread overview]
Message-ID: <20040507181114.GG29503@lug-owl.de> (raw)
In-Reply-To: <20040507165413.D16132@microdata-pos.de>
[-- Attachment #1: Type: text/plain, Size: 2286 bytes --]
On Fri, 2004-05-07 16:54:13 +0200, Michael Westermann <mw@microdata-pos.de>
wrote in message <20040507165413.D16132@microdata-pos.de>:
> diff -Nurp linux-2.4.26.old/drivers/char/serial.c linux-2.4.26/drivers/char/serial.c
> --- linux-2.4.26.old/drivers/char/serial.c 2004-02-18 14:36:31.000000000 +0100
> +++ linux-2.4.26/drivers/char/serial.c 2004-05-07 16:42:19.000000000 +0200
> @@ -769,9 +769,12 @@ static _INLINE_ void check_modem_status(
> }
> if (info->flags & ASYNC_CTS_FLOW) {
> if (info->tty->hw_stopped) {
> - if (status & UART_MSR_CTS) {
> + if (status & info->status_flow) {
> #if (defined(SERIAL_DEBUG_INTR) || defined(SERIAL_DEBUG_FLOW))
> - printk("CTS tx start...");
> + if (info->status_flow & UART_MSR_CTS)
> + printk("CTS tx start...");
> + else
> + printk("HW %x tx start...", info->status_flow);
A "\n" is missing here and was already missing in the initial version.
> #if (defined(SERIAL_DEBUG_INTR) || defined(SERIAL_DEBUG_FLOW))
> - printk("CTS tx stop...");
> + if (info->status_flow & UART_MSR_CTS)
> + printk("CTS tx stop...");
> + else
> + printk("HW %x tx stop...", info->status_flow);
Dito.
> --- linux-2.4.26.old/include/asm-i386/termbits.h 2000-01-21 01:05:26.000000000 +0100
> +++ linux-2.4.26/include/asm-i386/termbits.h 2004-05-07 16:43:39.000000000 +0200
> @@ -132,6 +132,7 @@ struct termios {
> #define B3000000 0010015
> #define B3500000 0010016
> #define B4000000 0010017
> +#define CHWFLOW 001000000000 /* flexible hw flow_ctrl */
> #define CIBAUD 002003600000 /* input baud rate (not used) */
> #define CMSPAR 010000000000 /* mark or space (stick) parity */
> #define CRTSCTS 020000000000 /* flow control */
> It's only i386 yet, but please comment on it!
I won't comment on the code itself, as I don't know the 2.4.x serial
driver all that good:) Of course, non-i386 code would be cool, too:)
MfG, JBG
--
Jan-Benedict Glaw jbglaw@lug-owl.de . +49-172-7608481
"Eine Freie Meinung in einem Freien Kopf | Gegen Zensur | Gegen Krieg
fuer einen Freien Staat voll Freier Bürger" | im Internet! | im Irak!
ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2004-05-07 20:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-07 14:54 [RFC] handshake variable with DTR DSR DCD Michael Westermann
2004-05-07 18:11 ` Jan-Benedict Glaw [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040507181114.GG29503@lug-owl.de \
--to=jbglaw@lug-owl.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mw@microdata-pos.de \
--cc=rusty@rustcorp.com.au \
--cc=tytso@MIT.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.