Re: [PATCH] udev callout for reading filesystem labels

[Kay Sievers <kay.sievers@vrfy.org>]

On Fri, May 07, 2004 at 08:25:34PM +0200, Arnd Bergmann wrote:
> - Call set_label_string() to normalize the dasd label like fs labels.
> - Improve set_label_string() to fix up other problems with the label
>   beside just trailing blanks.

> -static void set_label_string(struct volume_id *id, char *buf, int count)
> +void set_label_string(struct volume_id *id, char *buf, int count)
>  {
>  	int i;
>  
>  	memcpy(id->label_string, buf, count);
>  
> -	/* remove trailing whitespace */
> -	i = strlen(id->label_string);
> +	/* remove trailing whitespace and garbage */
> +	i = strnlen(id->label_string, VOLUME_ID_LABEL_SIZE);
>  	while (i--) {
> -		if (! isspace(id->label_string[i]))
> +		id->label_string[i+1] = '\0';
> +		if (isalnum(id->label_string[i]))
>  			break;
>  	}
> -	id->label_string[i+1] = '\0';
> +	/* replace remaining garbage with '_' */
> +	while (i--) {
> +		if (!isalnum(id->label_string[i]))
> +			id->label_string[i] = '_';

Hmm, doesn't it break UTF-8 characters, which are common in udf labels?
Should we better do it only for dasd and keep the set_label_string() private?

Kay


-------------------------------------------------------
This SF.Net email is sponsored by Sleepycat Software
Learn developer strategies Cisco, Motorola, Ericsson & Lucent use to 
deliver higher performing products faster, at low TCO.
http://www.sleepycat.com/telcomwpreg.php?From=osdnemail3
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel