All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oliver Feiler <kiza@gmx.net>
To: Andrew Morton <akpm@osdl.org>, John McGowan <jmcgowan@inch.com>
Cc: linux-kernel@vger.kernel.org, ext2-devel@lists.sourceforge.net
Subject: Re: Kernel 2.6.6: Removing the last large file does not reset filesystem properties
Date: Tue, 11 May 2004 11:53:32 +0200	[thread overview]
Message-ID: <200405111153.39614.kiza@gmx.net> (raw)
In-Reply-To: <20040511004956.70f7e17d.akpm@osdl.org>

[-- Attachment #1: signed data --]
[-- Type: text/plain, Size: 2008 bytes --]

On Tuesday 11 May 2004 09:49, Andrew Morton wrote:

> >   3: Was using Gimp 2.0 and used a tool. Got a 6 Gig swap file in
> > /tmp/gimp2 (there must be a problem with that tool). Closed gimp, got rid
> > of the swap file. Upon the next boot I got:
> >        FAILED!!
> >        Dropping to root command line for system maintenance
> >      (such fun ... entering the root password got more error messages
> > about missing programmes such as "id" and "test" - well, I have "/usr" on
> > another partition and it was not mounted).
>
> I think this is really an e2fsck/initscript problem.
>
> fsck saw that there were no large files on the fs, then fixed up the
> superblock to say that then returned an exit code which says "I modified
> the fs".
>
> The initscripts see that exit code and have a heart attack.
>
> What should happen is that fsck returns an exit code which says "I modified
> the fs, but everythig is OK".  And the initscripts should say "oh, cool"
> and keep booting.
>
> I don't know whether the problem lies with fsck or initscripts.

Yes, it's an issue with the initscripts (I'd say). I stumbled over this 
problem as well when upgrading e2fsprogs on a fairly old Slackware install. 
From the manpage of fsck:

The exit code returned by fsck is the sum of the following
       conditions:
            0    - No errors
            1    - File system errors corrected
            2    - System should be rebooted
[...]

The old Slackware init scripts (from 7.0 days I think) checked

 if [ $EXITCODE -gt 1 ] ; then
panic!

Newer fscks however also seem to return exit code 2 for "some errors 
corrected, please reboot". In Slack 9's initscripts this was changed to auto 
reboot in this case. I think this behaviour was changed in some version of 
fsck, but I'm note sure.

But admittedly I also got a slight heart attack when our server stopped 
booting with an error from fsck. ;)

	Oliver

-- 
Oliver Feiler  -  http://kiza.kcore.de/

[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2004-05-11  9:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-11  0:20 Kernel 2.6.6: Removing the last large file does not reset filesystem properties John McGowan
2004-05-11  7:49 ` Andrew Morton
2004-05-11  9:53   ` Oliver Feiler [this message]
2004-05-11 13:00   ` John McGowan
2004-05-11 15:32     ` Valdis.Kletnieks
2004-05-12  3:09       ` [Ext2-devel] " Theodore Ts'o
2004-05-12  4:25         ` Valdis.Kletnieks
2004-05-11 23:27     ` Bill Davidsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200405111153.39614.kiza@gmx.net \
    --to=kiza@gmx.net \
    --cc=akpm@osdl.org \
    --cc=ext2-devel@lists.sourceforge.net \
    --cc=jmcgowan@inch.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.