From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265075AbUEKXvn (ORCPT ); Tue, 11 May 2004 19:51:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265073AbUEKXs2 (ORCPT ); Tue, 11 May 2004 19:48:28 -0400 Received: from mail.kroah.org ([65.200.24.183]:13027 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S265069AbUEKXpn (ORCPT ); Tue, 11 May 2004 19:45:43 -0400 Date: Tue, 11 May 2004 16:43:29 -0700 From: Greg KH To: Valdis.Kletnieks@vt.edu Cc: Dave Airlie , Linux Kernel Mailing List , dri-devel@lists.sourceforge.net Subject: Re: From Eric Anholt: Message-ID: <20040511234329.GA27242@kroah.com> References: <200405112211.i4BMBQDZ006167@hera.kernel.org> <20040511222245.GA25644@kroah.com> <200405112334.i4BNYdjO018918@turing-police.cc.vt.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200405112334.i4BNYdjO018918@turing-police.cc.vt.edu> User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 11, 2004 at 07:34:39PM -0400, Valdis.Kletnieks@vt.edu wrote: > On Wed, 12 May 2004 00:20:51 BST, Dave Airlie said: > > > I just looked at drm.h and nearly all the ioctls use int, this file is > > included in user-space applications also at the moment, I'm worried > > changing all ints to __u32 will break some of these, anyone on DRI list > > care to comment? > > Is this a case where somebody is *really* including kernel headers in userspace > and we need to smack them, or are they using a copy that's been sanitized > (and possibly fixed)? Don't know, but how are you dealing with the issue that an "int" is different for different kernel sizes (64 vs 32) and userspace too. That's why you can't use it in an ioctl and expect things to work properly. thanks, greg k-h