From: Andi Kleen <ak@suse.de>
To: Anton Altaparmakov <aia21@cam.ac.uk>
Cc: akpm@osdl.org, torvalds@osdl.org, linux-kernel@vger.kernel.org,
yuri@acronis.com, linux-ntfs-dev@lists.sourceforge.net
Subject: Re: [2.6.6-BK] x86_64 has buggy ffs() implementation
Date: Wed, 12 May 2004 16:02:11 +0200 [thread overview]
Message-ID: <20040512160211.40bf63d9.ak@suse.de> (raw)
In-Reply-To: <1084369416.16624.53.camel@imp.csi.cam.ac.uk>
On Wed, 12 May 2004 14:43:37 +0100
Anton Altaparmakov <aia21@cam.ac.uk> wrote:
> Hi Andi, Andrew, Linus,
>
> x86_64 has incorrect include/asm-x86_64/bitops.h::ffs() implementation.
> It uses "g" instead of "rm" in the insline assembled bsfl instruction.
> (This was spotted by Yuri Per.)
>
> bsfl does not accept constant values but only memory ones. On i386 the
> correct "rm" is used.
>
> This causes NTFS build to fail as gcc optimizes a variable into a
> constant and ffs() then fails to assemble.
>
> Please apply below patch. Thanks!
Thanks. I applied it to my tree.
-Andi
next prev parent reply other threads:[~2004-05-12 14:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-12 13:43 [2.6.6-BK] x86_64 has buggy ffs() implementation Anton Altaparmakov
2004-05-12 14:02 ` Andi Kleen [this message]
2004-05-12 20:31 ` H. Peter Anvin
2004-05-12 21:08 ` Anton Altaparmakov
2004-05-12 21:11 ` Gabriel Paubert
2004-05-12 22:29 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040512160211.40bf63d9.ak@suse.de \
--to=ak@suse.de \
--cc=aia21@cam.ac.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
--cc=torvalds@osdl.org \
--cc=yuri@acronis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.