All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Reinauer <stepan@openbios.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Issues in implementing VESA support
Date: Sun, 16 May 2004 18:34:41 +0200	[thread overview]
Message-ID: <20040516163441.GD22889@openbios.org> (raw)
In-Reply-To: <87y8ntzbmb.fsf@marco.marco-g.com>

* Marco Gerards <metgerards@student.han.nl> [040515 22:19]:
> If there are no copyright issues, you can just copy them.  I am not
> sure if the person that wrote that code assigned his copyrights to the
> FSF.  If you know that, just copy it.  Otherwise Okuji can tell us.
 
Why would the FSF need the copyright for that piece of code? It being
GPL would be enough to make it usable in a new GPL project like grub2 is.

> > 3. If i have more than one file then should i put them in a separate
> >    driectory? If yes where (under term ) ?
> 
> It should go into grub2/term/i386/pc.  It depends on how many files
> you need to descide if a new directory should be created.  I think you
> can better do what seems the best to you.  Changing this later should
> not be a problem, right?

The hardware/VESA specific code should go below i386/pc. Any code that
can generically be reused for other machines should be placed in a
generic location. Changing this later will pretty much end up in a mess.
The file hierarchy should be an illustration of the logical program
structure. Moving the structure of the code around will end up in a
similar mess as grub 0.x

   Stefan




  parent reply	other threads:[~2004-05-16 16:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-15 19:49 Issues in implementing VESA support Shivram Khandeparker
2004-05-15 20:19 ` Marco Gerards
2004-05-16  7:44   ` Shivram Khandeparker
2004-05-17 11:53     ` Yoshinori K. Okuji
2004-05-16 16:34   ` Stefan Reinauer [this message]
2004-05-16 18:44     ` Marco Gerards
2004-05-17 11:55       ` Yoshinori K. Okuji
2004-05-17 11:51 ` Yoshinori K. Okuji

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040516163441.GD22889@openbios.org \
    --to=stepan@openbios.org \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.