From: Andrea Arcangeli <andrea@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: invalidate_inode_pages2
Date: Wed, 19 May 2004 03:08:17 +0200 [thread overview]
Message-ID: <20040519010817.GQ3044@dualathlon.random> (raw)
In-Reply-To: <20040518180028.2f3f5744.akpm@osdl.org>
On Tue, May 18, 2004 at 06:00:28PM -0700, Andrew Morton wrote:
> OK. Can we do a full pte invalidation and force a major fault?
we'd need to take the page_table_lock to do that from there, I find
safer to stay at the pagecache layer at that point inside the nfs
filesystem routines. the semantics of invalidate_inode_pages2 doesn't
require a synchronous invalidate with major fault, both O_DIRECT and nfs
cannot provide distributed shared memory anyways, all it matters is that
_future_ reads will trigger readpage again to provide inode invalidate
semantics.
> > > It's currently the case that pages which are mapped into process pagetables
> > > are always up to date, which sounds like a good invariant to have. This
> >
> > I already intentionally broke that invariant in 2.4 just to make exactly
> > this thing work safely, this is needed for correct O_DIRECT semantics
> > too.
> >
> > All it matters is that the pages are re-read after munmap+mmap.
> >
> > > changes that rule. I dunno if it'll break anything though.
> >
> > It didn't break anything in 2.4 AFIK.
>
> It might have caused some of the debug checks in fs/buffer.c to get angry
> when it's used by direct-IO. But they're gone now anyway...
sounds good then ;)
next prev parent reply other threads:[~2004-05-19 1:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-19 0:15 invalidate_inode_pages2 Andrea Arcangeli
2004-05-19 0:27 ` invalidate_inode_pages2 Andrew Morton
2004-05-19 0:51 ` invalidate_inode_pages2 Andrea Arcangeli
2004-05-19 1:00 ` invalidate_inode_pages2 Andrew Morton
2004-05-19 1:08 ` Andrea Arcangeli [this message]
2004-05-19 5:08 ` invalidate_inode_pages2 Jan Harkes
2004-05-19 5:16 ` invalidate_inode_pages2 Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040519010817.GQ3044@dualathlon.random \
--to=andrea@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.