From: Greg KH <greg@kroah.com>
To: John Zielinski <grim@undead.cc>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC] sysfs kobject that doesn't trigger hotplug events
Date: Tue, 18 May 2004 22:16:12 -0700 [thread overview]
Message-ID: <20040519051612.GA13657@kroah.com> (raw)
In-Reply-To: <40AAE603.1080707@undead.cc>
On Wed, May 19, 2004 at 12:43:47AM -0400, John Zielinski wrote:
> Greg KH wrote:
>
> >Your patch is not needed at all. Please read the first comment in the
> >kobject_hotplug() function to see how to prevent kobjects from creating
> >hotplug events.
> >
> >
>
> You mean this one?
>
> /* If this kobj does not belong to a kset, try to find a parent that does */
Oops, sorry, I meant the one in kset_hotplug() which is called by
kobject_hotplug() that says:
/* If the kset has a filter operation, call it. If it
* returns failure, no hotplug event is required. */
> The problem I saw with that is even though my kobject won't have a kset,
> my kobject's parent (or grandparent) may and I'll trigger that one. I'm
> not creating a new device driver, just extending one so I won't have
> control over that kobject's lineage.
So why are you creating a kobject, and not just attributes?
> The other way is to create a subsystem using subsytem_init but not to
> add it to the sysfs tree and then add my kobject to that kset and use
> the kset's hotplug filter to stop the hotplug events. This would
> require extra code and a little bit more memory usage for that kset, but
> I believe that would work. Any drawbacks to this method?
>
> Or am I missing something?
What exactly are you wanting to do? How about we start there.
thanks,
greg k-h
next prev parent reply other threads:[~2004-05-19 5:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-19 2:11 [RFC] sysfs kobject that doesn't trigger hotplug events John Zielinski
2004-05-19 3:18 ` Dmitry Torokhov
2004-05-21 1:19 ` John Zielinski
2004-05-19 3:34 ` Greg KH
2004-05-19 4:43 ` John Zielinski
2004-05-19 5:16 ` Greg KH [this message]
2004-05-22 1:38 ` John Zielinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040519051612.GA13657@kroah.com \
--to=greg@kroah.com \
--cc=grim@undead.cc \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.