Re: is this pretty much it (to patch kdm 3.2.2)?

[Luke Kenneth Casson Leighton <lkcl@lkcl.net>]

On Wed, May 19, 2004 at 08:34:24AM -0400, Stephen Smalley wrote:
> On Wed, 2004-05-19 at 03:42, Luke Kenneth Casson Leighton wrote:
> > +#ifdef WITH_SELINUX
> > +   if (is_selinux_enabled())
> 
> Should be if (is_selinux_enabled() > 0)

 ah, oops, then the wdm patch needs likewise mods.

> > +        if (get_default_context(name,NULL,&scontext))
> > +             LogError("Failed to get default security context for %s.", name);
> 
> Does LogError exit?  If not, you need to return here.

 no, it's just a printf wrapper.

> > +        Debug("setting security context to %s", scontext);
> > +        if (setexeccon(scontext)) {
> > +             freecon(scontext);
> > +             LogError("Failed to set exec security context %s for %s.", scontext, name);
> 
> As above, does LogError exit?
 
 hm, then does the wdm patch need the same attention?

 l.


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.