From: Erik Rigtorp <erik@rigtorp.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Olaf Hering <olh@suse.de>, Greg KH <greg@kroah.com>,
akpm@osdl.org, linux-usb-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [linux-usb-devel] [BK PATCH] USB changes for 2.6.6
Date: Wed, 19 May 2004 22:33:21 +0200 [thread overview]
Message-ID: <20040519203321.GA20979@linux.nu> (raw)
In-Reply-To: <Pine.LNX.4.58.0405151034500.10718@ppc970.osdl.org>
[-- Attachment #1: Type: text/plain, Size: 206 bytes --]
On Sat, May 15, 2004 at 10:37:10AM -0700, Linus Torvalds wrote:
> Replace all "led" with "cytherm". The code was crap, and would never have
> compiled with debugging on anyway.
I fixed my crappy code. :)
[-- Attachment #2: cytherm.patch --]
[-- Type: text/plain, Size: 2674 bytes --]
diff -urN linux-2.6.6/drivers/usb/misc/cytherm.c linux-2.6.6-cytherm/drivers/usb/misc/cytherm.c
--- linux-2.6.6/drivers/usb/misc/cytherm.c 2004-05-10 04:33:19.000000000 +0200
+++ linux-2.6.6-cytherm/drivers/usb/misc/cytherm.c 2004-05-19 22:23:58.000000000 +0200
@@ -122,12 +122,12 @@
retval = vendor_command(cytherm->udev, WRITE_RAM, BRIGHTNESS,
cytherm->brightness, buffer, 8);
if (retval)
- dev_dbg(&led->udev->dev, "retval = %d\n", retval);
+ dev_dbg(&cytherm->udev->dev, "retval = %d\n", retval);
/* Inform µC that we have changed the brightness setting */
retval = vendor_command(cytherm->udev, WRITE_RAM, BRIGHTNESS_SEM,
0x01, buffer, 8);
if (retval)
- dev_dbg(&led->udev->dev, "retval = %d\n", retval);
+ dev_dbg(&cytherm->udev->dev, "retval = %d\n", retval);
kfree(buffer);
@@ -161,13 +161,13 @@
/* read temperature */
retval = vendor_command(cytherm->udev, READ_RAM, TEMP, 0, buffer, 8);
if (retval)
- dev_dbg(&led->udev->dev, "retval = %d\n", retval);
+ dev_dbg(&cytherm->udev->dev, "retval = %d\n", retval);
temp = buffer[1];
/* read sign */
retval = vendor_command(cytherm->udev, READ_RAM, SIGN, 0, buffer, 8);
if (retval)
- dev_dbg(&led->udev->dev, "retval = %d\n", retval);
+ dev_dbg(&cytherm->udev->dev, "retval = %d\n", retval);
sign = buffer[1];
kfree(buffer);
@@ -205,7 +205,7 @@
/* check button */
retval = vendor_command(cytherm->udev, READ_RAM, BUTTON, 0, buffer, 8);
if (retval)
- dev_dbg(&led->udev->dev, "retval = %d\n", retval);
+ dev_dbg(&cytherm->udev->dev, "retval = %d\n", retval);
retval = buffer[1];
@@ -242,7 +242,7 @@
retval = vendor_command(cytherm->udev, READ_PORT, 0, 0, buffer, 8);
if (retval)
- dev_dbg(&led->udev->dev, "retval = %d\n", retval);
+ dev_dbg(&cytherm->udev->dev, "retval = %d\n", retval);
retval = buffer[1];
@@ -277,7 +277,7 @@
retval = vendor_command(cytherm->udev, WRITE_PORT, 0,
tmp, buffer, 8);
if (retval)
- dev_dbg(&led->udev->dev, "retval = %d\n", retval);
+ dev_dbg(&cytherm->udev->dev, "retval = %d\n", retval);
kfree(buffer);
@@ -302,7 +302,7 @@
retval = vendor_command(cytherm->udev, READ_PORT, 1, 0, buffer, 8);
if (retval)
- dev_dbg(&led->udev->dev, "retval = %d\n", retval);
+ dev_dbg(&cytherm->udev->dev, "retval = %d\n", retval);
retval = buffer[1];
@@ -337,7 +337,7 @@
retval = vendor_command(cytherm->udev, WRITE_PORT, 1,
tmp, buffer, 8);
if (retval)
- dev_dbg(&led->udev->dev, "retval = %d\n", retval);
+ dev_dbg(&cytherm->udev->dev, "retval = %d\n", retval);
kfree(buffer);
next prev parent reply other threads:[~2004-05-19 20:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-14 22:45 [BK PATCH] USB changes for 2.6.6 Greg KH
2004-05-15 11:32 ` [linux-usb-devel] " Olaf Hering
2004-05-15 17:37 ` Linus Torvalds
2004-05-16 17:51 ` David Brownell
2004-05-16 18:02 ` Linus Torvalds
2004-05-16 18:14 ` David Brownell
2004-05-16 18:22 ` Linus Torvalds
2004-05-16 18:28 ` David Brownell
2004-05-16 18:31 ` Greg KH
2004-05-19 20:33 ` Erik Rigtorp [this message]
2004-05-19 20:49 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040519203321.GA20979@linux.nu \
--to=erik@rigtorp.com \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=olh@suse.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.