From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@osdl.org>
Cc: adi@hexapodia.org, ak@muc.de, linux-kernel@vger.kernel.org
Subject: Re: overlaping printk
Date: Fri, 21 May 2004 09:00:59 +0200 [thread overview]
Message-ID: <20040521070059.GA2665@elte.hu> (raw)
In-Reply-To: <20040520161143.5677e9b7.akpm@osdl.org>
* Andrew Morton <akpm@osdl.org> wrote:
> Ingo Molnar <mingo@elte.hu> wrote:
> >
> > i've attached a new patch that does what Andi suggested too -
> > timestamping of the oopses. This way we will zap no sooner than 10
> > seconds after the first oops.
>
> I think that will do the wrong thing between 23 and 47 days uptime
> because time_after() will return an incorrect answer.
>
> How's this look?
> + static unsigned long oops_timestamp;
> +
> + if (time_after_eq(jiffies, oops_timestamp) &&
> + !time_after(jiffies, oops_timestamp + 30*HZ))
> return;
> +
looks good to me!
Ingo
next prev parent reply other threads:[~2004-05-21 6:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1XBEP-Mc-49@gated-at.bofh.it>
[not found] ` <1XBXw-13D-3@gated-at.bofh.it>
[not found] ` <1XWpp-zy-9@gated-at.bofh.it>
2004-05-20 14:53 ` overlaping printk Andi Kleen
2004-05-20 15:19 ` Ingo Molnar
2004-05-20 15:53 ` Ingo Molnar
2004-05-20 16:19 ` Andy Isaacson
2004-05-20 18:57 ` Ingo Molnar
2004-05-20 23:11 ` Andrew Morton
2004-05-21 7:00 ` Ingo Molnar [this message]
2004-05-19 15:55 Tuukka Toivonen
2004-05-19 16:03 ` Ricky Beam
2004-05-20 14:03 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2004-05-19 15:19 Ricky Beam
2004-05-19 15:26 ` Tigran Aivazian
2004-05-19 15:31 ` Ricky Beam
2004-05-19 15:39 ` Randy.Dunlap
2004-05-20 7:21 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040521070059.GA2665@elte.hu \
--to=mingo@elte.hu \
--cc=adi@hexapodia.org \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.