From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265820AbUEULXV (ORCPT ); Fri, 21 May 2004 07:23:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265821AbUEULXV (ORCPT ); Fri, 21 May 2004 07:23:21 -0400 Received: from gprs214-11.eurotel.cz ([160.218.214.11]:35200 "EHLO amd.ucw.cz") by vger.kernel.org with ESMTP id S265820AbUEULXO (ORCPT ); Fri, 21 May 2004 07:23:14 -0400 Date: Fri, 21 May 2004 13:23:06 +0200 From: Pavel Machek To: Herbert Xu , Andrew Morton , Patrick Mochel Cc: linux-kernel@vger.kernel.org Subject: swsusp vs. pmdisk [was Re: swsusp: fix swsusp with intel-agp] Message-ID: <20040521112306.GC976@elf.ucw.cz> References: <20040521100734.GA31550@elf.ucw.cz> <20040521111612.GA976@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040521111612.GA976@elf.ucw.cz> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.4i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi! > > > --- tmp/linux/arch/i386/mm/init.c 2004-05-20 23:08:05.000000000 +0200 > > > +++ linux/arch/i386/mm/init.c 2004-05-20 23:10:50.000000000 +0200 > > > @@ -331,6 +331,13 @@ > > > void zap_low_mappings (void) > > > { > > > int i; > > > + > > > +#ifdef CONFIG_SOFTWARE_SUSPEND > > > > Can you please define this for CONFIG_PM_DISK as well? Alternatively, > > you can do the same as you did in cpu.c and define this for > > CONFIG_PM. > > That would need few more parts to actually do something usefull on > pmdisk, right? Lowlevel code needs to know how to switch. What about killing pmdisk code, instead? Its old, its not maintained any more, and it is unneccessary duplicity of swsusp code. Patrick, in middle of april you claimed you'll have something "by the end of month". Can you either start looking after your code or give up and let me remove it? Pavel -- 934a471f20d6580d5aad759bf0d97ddc