From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] Re: request_region() on sound/oss/wavfront.c.
Date: Sat, 22 May 2004 22:43:43 +0000 [thread overview]
Message-ID: <20040522224343.GA1643@masina> (raw)
[-- Attachment #1: Type: text/plain, Size: 835 bytes --]
On 22/05/04 18:54 -0300, Gustavo Franco wrote:
> Hi list,
>
> [Patch aplied against 2.6.6-bk9 - compiles cleanly. ]
>
> I've added two error checks for request_region() calls on the source
> and replaced a check_region() with request_region().The release_region()
> calls seems to be ok, but let me known if i'm missing something.
>
> Comments?
>
You request same region twice...
> +++ sound/oss/wavfront.c 2004-05-22 18:28:38.000000000 -0300
> + if (!request_region (io_base, 16, "wavefront")) {
Few lines later there is a:
dev.base = io_base;
So this will print ugly error messages.
> + if(!request_region (dev.base+2, 6, "wavefront synth")) {
> + if(!request_region (dev.base+8, 8, "wavefront fx")) {
IMHO, you can just get rid of latter 2 request_region's.
And don't forget about release_region.
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next reply other threads:[~2004-05-22 22:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-22 22:43 Domen Puncer [this message]
2004-05-22 23:11 ` [Kernel-janitors] Re: request_region() on sound/oss/wavfront.c Domen Puncer
2004-05-23 1:12 ` Gustavo Franco
2004-05-23 7:09 ` Domen Puncer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040522224343.GA1643@masina \
--to=domen@coderock.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.