From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] Re: Replaces yield() with nicedelay() on
Date: Mon, 24 May 2004 13:24:40 +0000 [thread overview]
Message-ID: <20040524132440.GA23599@nd47> (raw)
[-- Attachment #1: Type: text/plain, Size: 1507 bytes --]
On 02/05/04 22:24 -0300, Gustavo Franco wrote:
> Hi,
>
> It's the last REDIFF, but i'm not replacing yield() with
> schedule_timeout() because there's a nicedelay() (maybe the
> usecs need to be tuned below) there:
>
>
> static inline void nicedelay(unsigned long usecs)
> {
> current->state = TASK_INTERRUPTIBLE;
> schedule_timeout(HZ);
> return;
> }
And usecs stands for??
Funny thing is that there are actualy uses of this function.
Also, please make -p1 applyable patches.
>
> Hope that helps,
> Gustavo Franco
>
> --- drivers/net/sb1000.c.orig 2004-04-28 20:50:17.000000000 -0300
> +++ drivers/net/sb1000.c 2004-04-28 20:49:10.000000000 -0300
> @@ -271,7 +271,7 @@
> timeout = jiffies + TimeOutJiffies;
> while (a & 0x80 || a & 0x40) {
> /* a little sleep */
> - yield();
> + nicedelay(10000);
>
>
> a = inb(ioaddr[0] + 7);
> if (time_after_eq(jiffies, timeout)) {
> @@ -295,7 +295,7 @@
> timeout = jiffies + TimeOutJiffies;
> while (a & 0x80 || !(a & 0x40)) {
> /* a little sleep */
> - yield();
> + nicedelay(10000);
>
>
> a = inb(ioaddr[1] + 6);
> if (time_after_eq(jiffies, timeout)) {
>
>
>
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.osdl.org
> http://lists.osdl.org/mailman/listinfo/kernel-janitors
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next reply other threads:[~2004-05-24 13:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-24 13:24 Domen Puncer [this message]
2004-05-24 14:31 ` [Kernel-janitors] Re: Replaces yield() with nicedelay() on Greg KH
2004-05-25 0:47 ` Gustavo Franco
2004-05-25 0:49 ` Gustavo Franco
2004-05-25 11:28 ` Domen Puncer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040524132440.GA23599@nd47 \
--to=domen@coderock.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.