From: Keith M Wesolowski <wesolows@foobazco.org>
To: sparclinux@vger.kernel.org
Subject: Re: PMD_SIZE and compile errors in 2.6.7-rc1
Date: Tue, 25 May 2004 03:40:42 +0000 [thread overview]
Message-ID: <20040525034042.GA29216@foobazco.org> (raw)
In-Reply-To: <20040525003820.GK2632@artsapartment.org>
On Mon, May 24, 2004 at 05:52:51PM -0700, William Lee Irwin III wrote:
> Hmm, preprocessor logic on the thing is probably ungood. How about this?
I like this a lot more. Art's approach is somewhat ugly but it
correctly points out that sparc32 no longer needs a variable PMD_SIZE
(it's always 1<<22 now). I'll fix that part up separately.
Thanks guys.
> Index: sparc32-2.6.7-rc1/mm/rmap.c
> =================================> --- sparc32-2.6.7-rc1.orig/mm/rmap.c 2004-05-24 08:50:32.354217000 -0700
> +++ sparc32-2.6.7-rc1/mm/rmap.c 2004-05-24 17:50:11.082902000 -0700
> @@ -537,11 +537,7 @@
> * there there won't be many ptes located within the scan cluster. In this case
> * maybe we could scan further - to the end of the pte page, perhaps.
> */
> -#define CLUSTER_SIZE (32 * PAGE_SIZE)
> -#if CLUSTER_SIZE > PMD_SIZE
> -#undef CLUSTER_SIZE
> -#define CLUSTER_SIZE PMD_SIZE
> -#endif
> +#define CLUSTER_SIZE min(32*PAGE_SIZE, PMD_SIZE)
> #define CLUSTER_MASK (~(CLUSTER_SIZE - 1))
>
> static int try_to_unmap_cluster(unsigned long cursor,
> -
> To unsubscribe from this list: send the line "unsubscribe sparclinux" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Keith M Wesolowski
prev parent reply other threads:[~2004-05-25 3:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-25 0:38 PMD_SIZE and compile errors in 2.6.7-rc1 Art Haas
2004-05-25 0:52 ` William Lee Irwin III
2004-05-25 3:40 ` Keith M Wesolowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040525034042.GA29216@foobazco.org \
--to=wesolows@foobazco.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.