From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264741AbUEYNYS (ORCPT ); Tue, 25 May 2004 09:24:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264746AbUEYNYR (ORCPT ); Tue, 25 May 2004 09:24:17 -0400 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:56246 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S264741AbUEYNYQ (ORCPT ); Tue, 25 May 2004 09:24:16 -0400 Date: Tue, 25 May 2004 14:24:13 +0100 From: Matthew Wilcox To: Arjan van de Ven Cc: Marcelo Tosatti , Matthew Wilcox , Greg KH , linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz Subject: Re: [BK PATCH] PCI Express patches for 2.4.27-pre3 Message-ID: <20040525132413.GD29154@parcelfarce.linux.theplanet.co.uk> References: <20040524210146.GA5532@kroah.com> <1085468008.2783.1.camel@laptop.fenrus.com> <20040525080006.GA1047@kroah.com> <20040525113231.GB29154@parcelfarce.linux.theplanet.co.uk> <20040525125452.GC3118@logos.cnet> <20040525130116.GA16852@devserv.devel.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040525130116.GA16852@devserv.devel.redhat.com> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 25, 2004 at 03:01:16PM +0200, Arjan van de Ven wrote: > > On Tue, May 25, 2004 at 09:54:53AM -0300, Marcelo Tosatti wrote: > > > > Marcelo, feel free to tell me otherwise if you do not want > > > > this in the 2.4 tree. > > > > Is this code necessary for PCI-Express devices/busses to work properly? > > afaik not. It's an enhancement to make config space access to them somewhat > faster, but they just work using the existing method. It also allows access to the top 3840 bytes of config space. The *spec* says you can't require access to that area for correct functioning of the device, but we all know how much people love to follow specs. -- "Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will diligently study them, and refuse to examine any refutations of them; and thus he will by and by convince himself that the war is just, and will thank God for the better sleep he enjoys after this process of grotesque self-deception." -- Mark Twain