All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dtor_core@ameritech.net>
To: netdev@oss.sgi.com
Cc: "David S. Miller" <davem@redhat.com>
Subject: [PATCH 2.6] TBF: do not oops when user tries to attach/show filter
Date: Tue, 25 May 2004 23:12:37 -0500	[thread overview]
Message-ID: <200405252312.37140.dtor_core@ameritech.net> (raw)

TBF does not allow attaching filters; implement dummy tcf_chain method to
avoid oopsing.

-- 
Dmitry


===================================================================


ChangeSet@1.1750, 2004-05-25 22:54:30-05:00, dtor_core@ameritech.net
  [NET_SCHED] Do not oops when user tries to attach a filter to a TBF qdisc.
              (TBF does not allow attaching filters as it has only one class,
              filter should be attached either to TBF's parent or to its child)


 sch_tbf.c |    6 ++++++
 1 files changed, 6 insertions(+)


===================================================================



diff -Nru a/net/sched/sch_tbf.c b/net/sched/sch_tbf.c
--- a/net/sched/sch_tbf.c	2004-05-25 22:57:37 -05:00
+++ b/net/sched/sch_tbf.c	2004-05-25 22:57:37 -05:00
@@ -495,6 +495,11 @@
 	}
 }
 
+static struct tcf_proto **tbf_find_tcf(struct Qdisc *sch, unsigned long cl)
+{
+	return NULL;
+}
+
 static struct Qdisc_class_ops tbf_class_ops =
 {
 	.graft		=	tbf_graft,
@@ -504,6 +509,7 @@
 	.change		=	tbf_change_class,
 	.delete		=	tbf_delete,
 	.walk		=	tbf_walk,
+	.tcf_chain	=	tbf_find_tcf,
 	.dump		=	tbf_dump_class,
 };
 

                 reply	other threads:[~2004-05-26  4:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200405252312.37140.dtor_core@ameritech.net \
    --to=dtor_core@ameritech.net \
    --cc=davem@redhat.com \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.