From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261234AbUEZXyy (ORCPT ); Wed, 26 May 2004 19:54:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261236AbUEZXyy (ORCPT ); Wed, 26 May 2004 19:54:54 -0400 Received: from fw.osdl.org ([65.172.181.6]:31397 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S261234AbUEZXyx (ORCPT ); Wed, 26 May 2004 19:54:53 -0400 Date: Wed, 26 May 2004 16:56:57 -0700 From: Andrew Morton To: Nigel Cunningham Cc: davej@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] SMP support for drain local pages v2. Message-Id: <20040526165657.36d84bf0.akpm@osdl.org> In-Reply-To: <40B52A7D.6090102@linuxmail.org> References: <40B473F7.4000100@linuxmail.org> <20040526223255.GB15278@redhat.com> <40B520A2.2060508@linuxmail.org> <20040526162607.0f177009.akpm@osdl.org> <40B52A7D.6090102@linuxmail.org> X-Mailer: Sylpheed version 0.9.7 (GTK+ 1.2.10; i586-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Nigel Cunningham wrote: > > Hi. > > Andrew Morton wrote: > > I think we only need a single entry point. Make it a new "drain_percpu_pages()" > > or such to break unconverted callers, switch callers of drain_local_pages() > > over to the new function. It needs no SMP ifdefs in it - on_each_cpu() will > > do the right thing on UP. > > > > But until something which needs this change is merged into the tree I'd say > > that this patch should live with the patch which requires it. > > CPU hotplugging uses drain_local_pages, Early versions did, but not now.