From: Nathan Scott <nathans@sgi.com>
To: dag@bakke.com
Cc: linux-kernel@vger.kernel.org, linux-xfs@oss.sgi.com
Subject: Re: xfsdump hangs - 2.6.6 && 2.6.7-rc1-bk3
Date: Thu, 27 May 2004 15:58:29 +1000 [thread overview]
Message-ID: <20040527055829.GA8981@frodo> (raw)
In-Reply-To: <20040526091315.17983.h012.c000.wm@mail.bakke.com.criticalpath.net>
On Wed, May 26, 2004 at 09:13:14AM -0700, dag@bakke.com wrote:
>
> I experience hangs with xfsdump, when dumping my rootfs to a USB 2.0
> ...
> http://thaifood.homeip.net/xfsdumphang/xfsdump.dmesg.txt
> ...
The xfsdump stack trace in there is the important one.
Can you try this patch and let me know how it goes?
thanks.
--
Nathan
--- fs/xfs/linux/xfs_buf.c.orig 2004-05-27 14:06:59.992936144 +1000
+++ fs/xfs/linux/xfs_buf.c 2004-05-27 14:08:21.548537808 +1000
@@ -370,8 +370,12 @@
retry:
page = find_or_create_page(mapping, first + i, gfp_mask);
if (unlikely(page == NULL)) {
- if (flags & PBF_READ_AHEAD)
+ if (flags & PBF_READ_AHEAD) {
+ for (--i; i >= 0; i--)
+ page_cache_release(bp->pb_pages[i]);
+ _pagebuf_free_pages(bp);
return -ENOMEM;
+ }
/*
* This could deadlock.
next prev parent reply other threads:[~2004-05-27 5:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-26 16:13 xfsdump hangs - 2.6.6 && 2.6.7-rc1-bk3 dag
2004-05-26 20:37 ` Nathan Scott
2004-05-27 5:58 ` Nathan Scott [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-05-26 17:01 dag
2004-05-27 8:09 dag
2004-05-27 8:18 ` Christoph Hellwig
2004-05-27 10:05 ` Nathan Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040527055829.GA8981@frodo \
--to=nathans@sgi.com \
--cc=dag@bakke.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.