All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Patrick Mochel <mochel@digitalimplant.org>
Cc: Todd Poynor <tpoynor@mvista.com>,
	linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH] Device runtime suspend/resume fixes try #2
Date: Fri, 28 May 2004 10:29:12 -0700	[thread overview]
Message-ID: <20040528172911.GA8576@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.50.0405281017290.4036-100000@monsoon.he.net>

On Fri, May 28, 2004 at 10:18:49AM -0700, Patrick Mochel wrote:
> 
> > --- linux-2.6.6-orig/drivers/base/power/runtime.c	2004-05-10 11:22:58.000000000 -0700
> > +++ linux-2.6.6-pm/drivers/base/power/runtime.c	2004-05-26 10:37:05.193449240 -0700
> > @@ -14,7 +14,10 @@
> >  {
> >  	if (!dev->power.power_state)
> >  		return;
> > -	resume_device(dev);
> > +	if (! resume_device(dev))
> > +		dev->power.power_state = 0;
> > +
> > +	return;
> 
> You don't need to explicitly return from a void function. :)

Oops, missed that.  I've fixed it up in my trees now.

thanks,

greg k-h

      reply	other threads:[~2004-05-28 17:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-26 18:29 [PATCH] Device runtime suspend/resume fixes try #2 Todd Poynor
2004-05-28 17:02 ` Greg KH
2004-05-28 17:18 ` Patrick Mochel
2004-05-28 17:29   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040528172911.GA8576@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mochel@digitalimplant.org \
    --cc=tpoynor@mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.