From: Russell King <rmk@arm.linux.org.uk>
To: cpufreq@www.linux.org.uk
Subject: cpufreq on ARM broken
Date: Sat, 29 May 2004 17:01:51 +0100 [thread overview]
Message-ID: <20040529170151.B3799@flint.arm.linux.org.uk> (raw)
Hi,
cpufreq doesn't appear to initialise on ARM - cpufreq_register_driver()
fails with -ENODEV.
This appears to be because we register cpus at subsys_initcall() time,
and cpufreq drivers at arch_initcall() time. We need cpufreq up and
running before any drivers are initialised since their timings depend
on the CPU clock rate.
The following patch appears to fix these problems.
--- linux-tolinus/arch/arm/mach-sa1100/cpu-sa1100.c Fri May 21 00:05:46 2004
+++ linux/arch/arm/mach-sa1100/cpu-sa1100.c Sat May 29 16:19:51 2004
@@ -230,8 +230,9 @@
}
static struct cpufreq_driver sa1100_driver = {
- .flags = (CPUFREQ_PANIC_OUTOFSYNC |
- CPUFREQ_PANIC_RESUME_OUTOFSYNC),
+ .flags = CPUFREQ_STICKY |
+ CPUFREQ_PANIC_OUTOFSYNC |
+ CPUFREQ_PANIC_RESUME_OUTOFSYNC,
.verify = sa11x0_verify_speed,
.target = sa1100_target,
.get = sa11x0_getspeed,
--- linux-tolinus/arch/arm/mach-sa1100/cpu-sa1110.c Fri May 21 00:05:46 2004
+++ linux/arch/arm/mach-sa1100/cpu-sa1110.c Sat May 29 16:19:35 2004
@@ -329,8 +329,9 @@
}
static struct cpufreq_driver sa1110_driver = {
- .flags = (CPUFREQ_PANIC_OUTOFSYNC |
- CPUFREQ_PANIC_RESUME_OUTOFSYNC),
+ .flags = CPUFREQ_STICKY |
+ CPUFREQ_PANIC_OUTOFSYNC |
+ CPUFREQ_PANIC_RESUME_OUTOFSYNC,
.verify = sa11x0_verify_speed,
.target = sa1110_target,
.get = sa11x0_getspeed,
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next reply other threads:[~2004-05-29 16:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-29 16:01 Russell King [this message]
2004-06-01 17:11 ` cpufreq on ARM broken Dave Jones
2004-06-02 12:21 ` Dominik Brodowski
2004-06-02 12:59 ` Dave Jones
2004-06-02 13:08 ` Dominik Brodowski
2004-06-02 21:36 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040529170151.B3799@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=cpufreq@www.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.